threads / patch / 61488

v2t/t0211-trace2-perf.sh: fix typo patern -> pattern

Subject: [PATCH v2] t/t0211-trace2-perf.sh: fix typo patern -> pattern

## tl;dr

2 messages between May 16, 2024 and May 16, 2024. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Marcel Telka· May 16, 2024, 07:45 UTC · lore

The bug went unnoticed because grep with null RE matches everything.

Signed-off-by: Marcel Telka <marcel@telka.sk>
---
 t/t0211-trace2-perf.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to t/t0211-trace2-perf.sh +1 −1

diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh
index 13ef69b92f..070fe7a5da 100755
--- a/t/t0211-trace2-perf.sh
+++ b/t/t0211-trace2-perf.sh
@@ -233,7 +233,7 @@ have_counter_event () {
 
 	pattern="d0|${thread}|${event}||||${category}|name:${name} value:${value}" &&
 
-	grep "${patern}" ${file}
+	grep "${pattern}" ${file}
 }
 
 test_expect_success 'global counter test/test1' '

Junio C Hamano· May 16, 2024, 16:34 UTC · re: Marcel Telka · lore

Re: [PATCH v2] t/t0211-trace2-perf.sh: fix typo patern -> pattern

Marcel Telka <marcel@telka.sk> writes:

Show 6 quoted lines

> The bug went unnoticed because grep with null RE matches everything.
>
> Signed-off-by: Marcel Telka <marcel@telka.sk>
> ---
>  t/t0211-trace2-perf.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks.  Will queue.

Show 13 quoted lines

> diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh
> index 13ef69b92f..070fe7a5da 100755
> --- a/t/t0211-trace2-perf.sh
> +++ b/t/t0211-trace2-perf.sh
> @@ -233,7 +233,7 @@ have_counter_event () {
>  
>  	pattern="d0|${thread}|${event}||||${category}|name:${name} value:${value}" &&
>  
> -	grep "${patern}" ${file}
> +	grep "${pattern}" ${file}
>  }
>  
>  test_expect_success 'global counter test/test1' '