[PATCH] gitlab-ci: fix installing dependencies for fuzz smoke tests

Patrick Steinhardt· May 9, 2024, 08:25 UTC · lore

There was a semantic merge conflict between 9cdeb34b96 (ci: merge scripts which install dependencies, 2024-04-12), which has merged "ci/install-docker-dependencies.sh" into "ci/install-dependencies.sh" and c7b228e000 (gitlab-ci: add smoke test for fuzzers, 2024-04-29), which has added a new fuzz smoke test job that makes use of the now-removed script.

Adapt the job to instead use the new script to install dependencies.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---

This patch is based on 0f3415f1f8 (The second batch, 2024-05-08), which contains the refactorings that merged the two dependency installation scripts into one. Other than that, I have pulled in two dependencies:

  - ps/enable-minimal-fuzzers-at-gitlab, which is the topic I'm fixing.

  - ps/ci-python-2-deprecation, which is required to make jobs based on
    "ubuntu:latest" pass in the first place. Other than that there is no
    textual dependency on this topic, which means that there is no need
    to pull this in as an actual dependency.

With this, all jobs pass again. See [1] for an example run.

Patrick

[1]: https://gitlab.com/gitlab-org/git/-/merge_requests/147

 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to .gitlab-ci.yml +1 −1

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 3836351d07..dfc3c88bec 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -100,7 +100,7 @@ test:fuzz-smoke-tests:
   variables:
     CC: clang
   before_script:
-    - ./ci/install-docker-dependencies.sh
+    - ./ci/install-dependencies.sh
   script:
     - ./ci/run-build-and-minimal-fuzzers.sh
 

base-commit: 33a6a5abc0e6c276c9a07468bd3500245c97ad72

-- 
2.44.0

Junio C Hamano· May 9, 2024, 15:46 UTC · re: Patrick Steinhardt · lore

Re: [PATCH] gitlab-ci: fix installing dependencies for fuzz smoke tests

Patrick Steinhardt <ps@pks.im> writes:

Show 6 quoted lines

> There was a semantic merge conflict between 9cdeb34b96 (ci: merge
> scripts which install dependencies, 2024-04-12), which has merged
> "ci/install-docker-dependencies.sh" into "ci/install-dependencies.sh"
> and c7b228e000 (gitlab-ci: add smoke test for fuzzers, 2024-04-29),
> which has added a new fuzz smoke test job that makes use of the
> now-removed script.

Ah, I should have been more carefully paying attention to what happens in ci/ directory (which I have largely been ignoring).

Thanks for fixing it up.

patchgitlab-ci: fix installing dependencies for fuzz smoke tests