# [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog 3 messages from 2024-04-20 to 2024-04-22. Participants: Orgad Shaneh via GitGitGadget, Junio C Hamano, Patrick Steinhardt. Thread: https://gitlist.dev/t/61345 ## Orgad Shaneh via GitGitGadget, 2024-04-20 19:51 Subject: [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog Message-ID: URL: https://gitlist.dev/e/pull.1711.git.git.1713642690371.gitgitgadget%40gmail.com ``` From: Orgad Shaneh Signed-off-by: Orgad Shaneh --- docs: remove duplicate entry and fix typo in 2.45 changelog Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1711%2Forgads%2Fchangelog-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1711/orgads/changelog-v1 Pull-Request: https://github.com/git/git/pull/1711 Documentation/RelNotes/2.45.0.txt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Documentation/RelNotes/2.45.0.txt b/Documentation/RelNotes/2.45.0.txt index 0570dcd8773..38458664407 100644 --- a/Documentation/RelNotes/2.45.0.txt +++ b/Documentation/RelNotes/2.45.0.txt @@ -100,7 +100,7 @@ Performance, Internal Implementation, Development Support etc. * The way placeholders are to be marked-up in documentation have been specified; use "__" to typeset the word inside a pair - of emphasized. + of emphasized. * "git --no-lazy-fetch cmd" allows to run "cmd" while disabling lazy fetching of objects from the promisor remote, which may be handy @@ -110,9 +110,6 @@ Performance, Internal Implementation, Development Support etc. clean.requireForce has been simplified, together with the documentation. - * The code to iterate over refs with the reftable backend has seen - some optimization. - * Uses of xwrite() helper have been audited and updated for better error checking and simpler code. base-commit: ae3196a5ea84a9e88991d576020cf66512487088 -- gitgitgadget ``` ## Junio C Hamano, 2024-04-21 18:29 Subject: Re: [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog Message-ID: URL: https://gitlist.dev/e/xmqqseze1seh.fsf%40gitster.g In-Reply-To: ``` "Orgad Shaneh via GitGitGadget" writes: > From: Orgad Shaneh > > Signed-off-by: Orgad Shaneh > --- > > Documentation/RelNotes/2.45.0.txt | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/Documentation/RelNotes/2.45.0.txt b/Documentation/RelNotes/2.45.0.txt > index 0570dcd8773..38458664407 100644 > --- a/Documentation/RelNotes/2.45.0.txt > +++ b/Documentation/RelNotes/2.45.0.txt > @@ -100,7 +100,7 @@ Performance, Internal Implementation, Development Support etc. > > * The way placeholders are to be marked-up in documentation have been > specified; use "__" to typeset the word inside a pair > - of emphasized. > + of emphasized. Thanks. > @@ -110,9 +110,6 @@ Performance, Internal Implementation, Development Support etc. > clean.requireForce has been simplified, together with the > documentation. > > - * The code to iterate over refs with the reftable backend has seen > - some optimization. > - > * Uses of xwrite() helper have been audited and updated for better > error checking and simpler code. Interesting. It is likely that we had two topics that did things that summarised down to the same description. They are 448a74e1 (Merge branch 'ps/reftable-iteration-perf-part2', 2024-03-14) 9f67cbd0 (Merge branch 'ps/reftable-iteration-perf', 2024-02-26) I do not know which is better between removing the second entry (which is what this patch is doing, as the entries are in chronological order of the topics' graduation to 'master'), or amending it to say "has seen some more optimization". ``` ## Patrick Steinhardt, 2024-04-22 05:51 Subject: Re: [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog Message-ID: URL: https://gitlist.dev/e/ZiX616G0PPp1jICn%40tanuki In-Reply-To: ``` On Sun, Apr 21, 2024 at 11:29:10AM -0700, Junio C Hamano wrote: > "Orgad Shaneh via GitGitGadget" writes: > > > From: Orgad Shaneh > > > > Signed-off-by: Orgad Shaneh > > @@ -110,9 +110,6 @@ Performance, Internal Implementation, Development Support etc. > > clean.requireForce has been simplified, together with the > > documentation. > > > > - * The code to iterate over refs with the reftable backend has seen > > - some optimization. > > - > > * Uses of xwrite() helper have been audited and updated for better > > error checking and simpler code. > > Interesting. It is likely that we had two topics that did things > that summarised down to the same description. They are > > 448a74e1 (Merge branch 'ps/reftable-iteration-perf-part2', 2024-03-14) > 9f67cbd0 (Merge branch 'ps/reftable-iteration-perf', 2024-02-26) > > I do not know which is better between removing the second entry > (which is what this patch is doing, as the entries are in > chronological order of the topics' graduation to 'master'), or > amending it to say "has seen some more optimization". Squashing these into a single entry should be fine in my opinion. The split was artificial anyway to make the review process easier. Patrick ```