unintelligible error fatal: empty ident name (for <>) not allowed

Michal Suchánek· Mar 10, 2024, 15:15 UTC · lore

git version 2.44.0

git am -3
../linux-6.8~rc1/debian/patches/rk3588/dw-hdmi-rockchip-avoid-tmds-spam.patch
Applying: dw-hdmi-rockchip: avoid spamming 'use tmds mode' in dmesg
fatal: empty ident name (for <>) not allowed

What's wrong with that patch, specifically?

Can you tell?

I cannot, at all.

Already applied 70 other patches so it's not git configuration.

Thanks

Michal

Torsten Bögershausen· Mar 10, 2024, 16:03 UTC · re: Michal Suchánek · lore

Re: unintelligible error fatal: empty ident name (for <>) not allowed

On Sun, Mar 10, 2024 at 04:15:33PM +0100, Michal Suchánek wrote:

Show 11 quoted lines

> git version 2.44.0
>
> git am -3
> ../linux-6.8~rc1/debian/patches/rk3588/dw-hdmi-rockchip-avoid-tmds-spam.patch
> Applying: dw-hdmi-rockchip: avoid spamming 'use tmds mode' in dmesg
> fatal: empty ident name (for <>) not allowed
>
>
> What's wrong with that patch, specifically?
>
> Can you tell?

The message seems to come from ident.c

Is there any chance to get a copy of that very file ?

Or more details ?

Michal Suchánek· Mar 10, 2024, 16:42 UTC · re: Torsten Bögershausen · lore

Re: unintelligible error fatal: empty ident name (for <>) not allowed

On Sun, Mar 10, 2024 at 05:03:38PM +0100, Torsten Bögershausen wrote:

Show 16 quoted lines

> On Sun, Mar 10, 2024 at 04:15:33PM +0100, Michal Suchánek wrote:
> > git version 2.44.0
> >
> > git am -3
> > ../linux-6.8~rc1/debian/patches/rk3588/dw-hdmi-rockchip-avoid-tmds-spam.patch
> > Applying: dw-hdmi-rockchip: avoid spamming 'use tmds mode' in dmesg
> > fatal: empty ident name (for <>) not allowed
> >
> >
> > What's wrong with that patch, specifically?
> >
> > Can you tell?
> 
> The message seems to come from ident.c
> 
> Is there any chance to get a copy of that very file ?

Sure, I can get a file that reproduces the problem.

> Or more details ?

I would like to know more details as well.

When gcc gives an error it tells me exactly on what line and what character the error is, giving the errorneous text in question.

Here I have absolutely no idea what the problem is.

Thanks

Michal

From f3b68d2a91d3f443a8b86173c9cac01897075b84
Author: Lukas F. Hartmann <lukas@mntre.com>
Date:   Tue Mar 5 21:07:08 2024 +0100
Subject: dw-hdmi-rockchip: avoid spamming 'use tmds mode' in dmesg

diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
index dd154855a38a..b10a70870a10 100644
--- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
@@ -737,7 +737,7 @@ static void hdmi_select_link_config(struct rockchip_hdmi *hdmi,
 	hdmi->link_cfg.rate_per_lane = max_rate_per_lane;
 
 	if (!max_frl_rate || (tmdsclk < HDMI20_MAX_RATE && mode.clock < HDMI20_MAX_RATE)) {
-		dev_info(hdmi->dev, "use tmds mode\n");
+		//dev_info(hdmi->dev, "use tmds mode\n");
 		hdmi->link_cfg.frl_mode = false;
 		return;
 	}