threads / patch / 6089

patch, 2 partsUse extended SHA1 syntax in merge-recursive conflicts.

Subject: [PATCH 1/2] Use extended SHA1 syntax in merge-recursive conflicts.

## tl;dr

One message between Dec 23, 2006 and Dec 23, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Shawn O. Pearce· Dec 23, 2006, 08:44 UTC · lore

When we get a line-level conflict in merge-recursive and print out the two sides in the conflict hunk header and footer we should use the standard extended SHA1 syntax to specify the specific blob, as this allows the user to copy and paste the line right into 'git show' to view the complete version.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 merge-recursive.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Show changes to merge-recursive.c +2 −2
diff --git a/merge-recursive.c b/merge-recursive.c
index ae7ae4c..abebb95 100644
--- a/merge-recursive.c
+++ b/merge-recursive.c
@@ -649,8 +649,8 @@ static struct merge_file_info merge_file(struct diff_filespec *o,
 			char *name1, *name2;
 			int merge_status;
 
-			name1 = xstrdup(mkpath("%s/%s", branch1, a->path));
-			name2 = xstrdup(mkpath("%s/%s", branch2, b->path));
+			name1 = xstrdup(mkpath("%s:%s", branch1, a->path));
+			name2 = xstrdup(mkpath("%s:%s", branch2, b->path));
 
 			fill_mm(o->sha1, &orig);
 			fill_mm(a->sha1, &src1);
-- 
1.4.4.3.g87d8

← back to recent threads