# [PATCH] t4129: prevent loss of exit code due to the use of pipes 2 messages from 2024-01-10 to 2024-01-10. Participants: Chandra Pratap via GitGitGadget, Junio C Hamano. Thread: https://gitlist.dev/t/60717 ## Chandra Pratap via GitGitGadget, 2024-01-10 12:54 Subject: [PATCH] t4129: prevent loss of exit code due to the use of pipes Message-ID: URL: https://gitlist.dev/e/pull.1636.git.1704891257544.gitgitgadget%40gmail.com ``` From: Chandra Pratap Piping the output of git commands like git-ls-files to another command (grep in this case) hides the exit code returned by these commands. Prevent this by storing the output of git-ls-files to a temporary file and then "grep-ping" from that file. Replace grep with test_grep as the latter is more verbose when it fails. Signed-off-by: Chandra Pratap --- t4129: prevent loss of exit code due to the use of pipes Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1636%2FChand-ra%2Ftest_pipe-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1636/Chand-ra/test_pipe-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/1636 t/t4129-apply-samemode.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/t/t4129-apply-samemode.sh b/t/t4129-apply-samemode.sh index e7a7295f1b6..ffabeafa213 100755 --- a/t/t4129-apply-samemode.sh +++ b/t/t4129-apply-samemode.sh @@ -41,7 +41,8 @@ test_expect_success FILEMODE 'same mode (index only)' ' chmod +x file && git add file && git apply --cached patch-0.txt && - git ls-files -s file | grep "^100755" + git ls-files -s file > ls-files-output && + test_grep "^100755" ls-files-output ' test_expect_success FILEMODE 'mode update (no index)' ' @@ -60,7 +61,8 @@ test_expect_success FILEMODE 'mode update (with index)' ' test_expect_success FILEMODE 'mode update (index only)' ' git reset --hard && git apply --cached patch-1.txt && - git ls-files -s file | grep "^100755" + git ls-files -s file > ls-files-output && + test_grep "^100755" ls-files-output ' test_expect_success FILEMODE 'empty mode is rejected' ' base-commit: a54a84b333adbecf7bc4483c0e36ed5878cac17b -- gitgitgadget ``` ## Junio C Hamano, 2024-01-10 17:25 Subject: Re: [PATCH] t4129: prevent loss of exit code due to the use of pipes Message-ID: URL: https://gitlist.dev/e/xmqqwmshcd8r.fsf%40gitster.g In-Reply-To: ``` "Chandra Pratap via GitGitGadget" writes: > t/t4129-apply-samemode.sh | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Looks good. Will queue with two instances of a minor style fix (see below). > diff --git a/t/t4129-apply-samemode.sh b/t/t4129-apply-samemode.sh > index e7a7295f1b6..ffabeafa213 100755 > --- a/t/t4129-apply-samemode.sh > +++ b/t/t4129-apply-samemode.sh > @@ -41,7 +41,8 @@ test_expect_success FILEMODE 'same mode (index only)' ' > chmod +x file && > git add file && > git apply --cached patch-0.txt && > - git ls-files -s file | grep "^100755" > + git ls-files -s file > ls-files-output && Redirection operator ">" and "<" sticks to the file in question (look for "> " and "< " in this file and you'd find none), i.e. git ls-files -s file >ls-files-output && Thanks. ```