# [PATCH] builtin/reflog.c: fix dry-run option short name 2 messages from 2023-11-26 to 2023-11-26. Participants: Josh Brobst, Junio C Hamano. Thread: https://gitlist.dev/t/60559 ## Josh Brobst, 2023-11-26 00:05 Subject: [PATCH] builtin/reflog.c: fix dry-run option short name Message-ID: <20231126000514.85509-1-josh@brob.st> URL: https://gitlist.dev/e/20231126000514.85509-1-josh%40brob.st ``` The documentation for reflog states that the --dry-run option of the expire and delete subcommands has a corresponding short name, -n. However, 33d7bdd645 (builtin/reflog.c: use parse-options api for expire, delete subcommands, 2022-01-06) did not include this short name in the new options parsing. Re-add the short name in the new dry-run option definitions. Signed-off-by: Josh Brobst --- builtin/reflog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/reflog.c b/builtin/reflog.c index df63a5892e..a39962df69 100644 --- a/builtin/reflog.c +++ b/builtin/reflog.c @@ -248,7 +248,7 @@ static int cmd_reflog_expire(int argc, const char **argv, const char *prefix) int verbose = 0; reflog_expiry_should_prune_fn *should_prune_fn = should_expire_reflog_ent; const struct option options[] = { - OPT_BIT(0, "dry-run", &flags, N_("do not actually prune any entries"), + OPT_BIT('n', "dry-run", &flags, N_("do not actually prune any entries"), EXPIRE_REFLOGS_DRY_RUN), OPT_BIT(0, "rewrite", &flags, N_("rewrite the old SHA1 with the new SHA1 of the entry that now precedes it"), @@ -368,7 +368,7 @@ static int cmd_reflog_delete(int argc, const char **argv, const char *prefix) int verbose = 0; const struct option options[] = { - OPT_BIT(0, "dry-run", &flags, N_("do not actually prune any entries"), + OPT_BIT('n', "dry-run", &flags, N_("do not actually prune any entries"), EXPIRE_REFLOGS_DRY_RUN), OPT_BIT(0, "rewrite", &flags, N_("rewrite the old SHA1 with the new SHA1 of the entry that now precedes it"), -- 2.42.0 ``` ## Junio C Hamano, 2023-11-26 08:44 Subject: Re: [PATCH] builtin/reflog.c: fix dry-run option short name Message-ID: URL: https://gitlist.dev/e/xmqqleak6gzy.fsf%40gitster.g In-Reply-To: <20231126000514.85509-1-josh@brob.st> ``` Josh Brobst writes: > The documentation for reflog states that the --dry-run option of the > expire and delete subcommands has a corresponding short name, -n. > However, 33d7bdd645 (builtin/reflog.c: use parse-options api for expire, > delete subcommands, 2022-01-06) did not include this short name in the > new options parsing. > > Re-add the short name in the new dry-run option definitions. Perfect. Thanks for spotting and doing necessary archaeology. ```