# [PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635 4 messages from 2023-10-09 to 2023-10-09. Participants: Naomi Ibe, Christian Couder. Thread: https://gitlist.dev/t/60329 ## Naomi Ibe, 2023-10-09 01:16 Subject: [PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635 Message-ID: <20231009011652.1791-1-naomi.ibeh69@gmail.com> URL: https://gitlist.dev/e/20231009011652.1791-1-naomi.ibeh69%40gmail.com ``` From: Naomi Signed-off-by: Naomi Ibe --- builtin/add.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/builtin/add.c b/builtin/add.c index c27254a5cd..5126d2ede3 100644 --- a/builtin/add.c +++ b/builtin/add.c @@ -182,7 +182,7 @@ static int edit_patch(int argc, const char **argv, const char *prefix) git_config(git_diff_basic_config, NULL); /* no "diff" UI options */ if (repo_read_index(the_repository) < 0) - die(_("Could not read the index")); + die(_("could not read the index")); repo_init_revisions(the_repository, &rev, prefix); rev.diffopt.context = 7; @@ -200,15 +200,15 @@ static int edit_patch(int argc, const char **argv, const char *prefix) die(_("editing patch failed")); if (stat(file, &st)) - die_errno(_("Could not stat '%s'"), file); + die_errno(_("could not stat '%s'"), file); if (!st.st_size) - die(_("Empty patch. Aborted.")); + die(_("empty patch. aborted")); child.git_cmd = 1; strvec_pushl(&child.args, "apply", "--recount", "--cached", file, NULL); if (run_command(&child)) - die(_("Could not apply '%s'"), file); + die(_("could not apply '%s'"), file); unlink(file); free(file); @@ -568,7 +568,7 @@ int cmd_add(int argc, const char **argv, const char *prefix) finish: if (write_locked_index(&the_index, &lock_file, COMMIT_LOCK | SKIP_IF_UNCHANGED)) - die(_("Unable to write new index file")); + die(_("unable to write new index file")); dir_clear(&dir); clear_pathspec(&pathspec); -- 2.36.1.windows.1 ``` ## Christian Couder, 2023-10-09 07:27 Subject: Re: [PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635 Message-ID: URL: https://gitlist.dev/e/CAP8UFD35DBBwQ1Mgc%2BNGVoh1ReLncAz9OJF3Yj%2B%2BFFrESw8rtw%40mail.gmail.com In-Reply-To: <20231009011652.1791-1-naomi.ibeh69@gmail.com> ``` On Mon, Oct 9, 2023 at 3:17 AM Naomi Ibe wrote: > > From: Naomi First the subject should start, after "[PATCH 1/1][Outreachy]", with the area of the code you are changing followed by ":", so here "add:" (no need for ".c"). Also even if the subject gives a lot of information already, it's better to use the body of the commit message to give a bit more context and details. For example here either the subject or the body of the commit message should say which specific guideline(s) the patch is enforcing. > Signed-off-by: Naomi Ibe > --- > builtin/add.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Otherwise the patch looks good to me. Thanks! ``` ## Naomi Ibe, 2023-10-09 07:57 Subject: Re: [PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635 Message-ID: URL: https://gitlist.dev/e/CACS%3DG2zcU%2Bo6av%3DCQy7WAG7DZmNEERcPqB_W3Cmub4w25V3K4g%40mail.gmail.com In-Reply-To: ``` Thank you very much for the feedback Christian, I'd definitely keep this in mind the next time I'm creating/sending a patch. You also said asides working on my commit message, the patch looks good, but as I'm applying to Outreachy, I need to send in my proof of contribution as a link of a task I worked on. Would sending a link of the mailing list , with the url of this patch I just worked on suffice?Something like this : https://public-inbox.org/git/20231009011652.1791-1-naomi.ibeh69@gmail.com/T/#u I ask because since I used patches to send to Git , I have no pull request link to submit. On Mon, Oct 9, 2023 at 8:28 AM Christian Couder wrote: > > On Mon, Oct 9, 2023 at 3:17 AM Naomi Ibe wrote: > > > > From: Naomi > > First the subject should start, after "[PATCH 1/1][Outreachy]", with > the area of the code you are changing followed by ":", so here "add:" > (no need for ".c"). > > Also even if the subject gives a lot of information already, it's > better to use the body of the commit message to give a bit more > context and details. For example here either the subject or the body > of the commit message should say which specific guideline(s) the patch > is enforcing. > > > Signed-off-by: Naomi Ibe > > --- > > builtin/add.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > Otherwise the patch looks good to me. > > Thanks! ``` ## Christian Couder, 2023-10-09 08:22 Subject: Re: [PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635 Message-ID: URL: https://gitlist.dev/e/CAP8UFD2hCPh2cVZ_xUeJU0OLw9RzJwGiT9TperzRyYwcw4uvPQ%40mail.gmail.com In-Reply-To: ``` On Mon, Oct 9, 2023 at 9:57 AM Naomi Ibe wrote: > > Thank you very much for the feedback Christian, I'd definitely keep > this in mind the next time I'm creating/sending a patch. Great! > You also said asides working on my commit message, the patch looks > good, Yeah, but first others might find some issues in the patch itself, also, as I say elsewhere, I think it's worth it for you to send a version 2 of the patch that fixes the commit message issues I pointed out. > but as I'm applying to Outreachy, I need to send in my proof of > contribution as a link of a task I worked on. > Would sending a link of the mailing list , with the url of this patch > I just worked on suffice?Something like this : > https://public-inbox.org/git/20231009011652.1791-1-naomi.ibeh69@gmail.com/T/#u > I ask because since I used patches to send to Git , I have no pull > request link to submit. Yeah, links to the emails you sent in a mailing list archive (Public Inbox or lore.kernel.org/git) are fine. ```