# git.kernel.org disconnects when git-1.3.3 tries to pull changes

3 messages from 2006-10-24 to 2006-10-30. Participants: Simon Arlott, Junio C Hamano, Jon Loeliger.
Thread: https://gitlist.dev/t/6022

## Simon Arlott, 2006-10-24 00:03

Subject: git.kernel.org disconnects when git-1.3.3 tries to pull changes
Message-ID: <453D583E.3010601@simon.arlott.org.uk>
URL: https://gitlist.dev/e/453D583E.3010601%40simon.arlott.org.uk

```
$ git --version
git version 1.3.3

$ git pull
fatal: unexpected EOF
Fetch failure: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git/

[pid 14283] write(3, "0046git-upload-pack /pub/scm/linux/kernel/git/torvalds/linux-2.6.git/\n", 70) = 70

$ nc -vv git.kernel.org git
DNS fwd/rev mismatch: zeus-pub.kernel.org != zeus-pub1.kernel.org
DNS fwd/rev mismatch: zeus-pub.kernel.org != zeus-pub2.kernel.org
zeus-pub.kernel.org [204.152.191.5] 9418 (git) open
0046git-upload-pack /pub/scm/linux/kernel/git/torvalds/linux-2.6.git/
 sent 70, rcvd 0
$

<pasky> the difference seems to be just that newer git version sends a host information
<pasky> anyway, this isn't supposed to happen
<pasky> could you mail the mailing list, please?

-- 
Simon Arlott


```

## Junio C Hamano, 2006-10-24 01:23

Subject: Re: git.kernel.org disconnects when git-1.3.3 tries to pull changes
Message-ID: <7vbqo2wlpl.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vbqo2wlpl.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <453D583E.3010601@simon.arlott.org.uk>

```
Yes, this is a recent breakage.  Thanks for bringing it up.

We need at least a fix like this in 'maint'.

diff --git a/daemon.c b/daemon.c
index ad84928..e66bb80 100644
--- a/daemon.c
+++ b/daemon.c
@@ -450,6 +450,8 @@ void fill_in_extra_table_entries(struct 
 	 * Replace literal host with lowercase-ized hostname.
 	 */
 	hp = interp_table[INTERP_SLOT_HOST].value;
+	if (!hp)
+		return;
 	for ( ; *hp; hp++)
 		*hp = tolower(*hp);
 
@@ -544,8 +546,10 @@ #endif
 		loginfo("Extended attributes (%d bytes) exist <%.*s>",
 			(int) pktlen - len,
 			(int) pktlen - len, line + len + 1);
-	if (len && line[len-1] == '\n')
+	if (len && line[len-1] == '\n') {
 		line[--len] = 0;
+		pktlen--;
+	}
 
 	/*
 	 * Initialize the path interpolation table for this connection.

```

## Jon Loeliger, 2006-10-30 19:53

Subject: Re: git.kernel.org disconnects when git-1.3.3 tries to pull changes
Message-ID: <1162238005.18278.33.camel@cashmere.sps.mot.com>
URL: https://gitlist.dev/e/1162238005.18278.33.camel%40cashmere.sps.mot.com
In-Reply-To: <7vbqo2wlpl.fsf@assigned-by-dhcp.cox.net>

```
On Mon, 2006-10-23 at 20:23, Junio C Hamano wrote:
> Yes, this is a recent breakage.  Thanks for bringing it up.
> 
> We need at least a fix like this in 'maint'.

Oooo...  Sorry.  That looks like my bad.

Thanks.

jdl


```