# [PATCH] Fix regression tests on Cygwin 5 messages from 2006-10-23 to 2006-10-25. Participants: Lars Hjemli, Johannes Schindelin, Junio C Hamano. Thread: https://gitlist.dev/t/6016 ## Lars Hjemli, 2006-10-23 19:34 Subject: [PATCH] Fix regression tests on Cygwin Message-ID: <11616320733093-git-send-email-hjemli@gmail.com> URL: https://gitlist.dev/e/11616320733093-git-send-email-hjemli%40gmail.com ``` On Cygwin, "make test" failes due to missing ".exe" a couple of places. This fixes it, in a somewhat ugly way.... Signed-off-by: Lars Hjemli --- t/t0000-basic.sh | 9 ++++++++- t/test-lib.sh | 10 +++++++++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh index 2c9bbb5..41d53be 100755 --- a/t/t0000-basic.sh +++ b/t/t0000-basic.sh @@ -25,7 +25,14 @@ # or have too old python without subproc # out before running any tests. Also catch the bogosity of trying # to run tests without building while we are at it. -../git >/dev/null +X= +uname=$(uname -o) +if test "$uname" = "Cygwin" +then + X=".exe" +fi + +../git$X >/dev/null if test $? != 1 then echo >&2 'You do not seem to have built git yet.' diff --git a/t/test-lib.sh b/t/test-lib.sh index 2488e6e..8a64f6e 100755 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -43,6 +43,14 @@ case $(echo $GIT_TRACE |tr "[A-Z]" "[a-z ;; esac +X= +uname=$(uname -o) +if test "$uname" = "Cygwin" +then + X=".exe" +fi + + # Each test should start with something like this, after copyright notices: # # test_description='Description of this test... @@ -175,7 +183,7 @@ test_create_repo () { repo="$1" mkdir "$repo" cd "$repo" || error "Cannot setup test environment" - "$GIT_EXEC_PATH/git" init-db --template=$GIT_EXEC_PATH/templates/blt/ 2>/dev/null || + "$GIT_EXEC_PATH/git$X" init-db --template=$GIT_EXEC_PATH/templates/blt/ 2>/dev/null || error "cannot run git init-db -- have you built things yet?" mv .git/hooks .git/hooks-disabled cd "$owd" -- 1.4.3.1.g1688 ``` ## Johannes Schindelin, 2006-10-24 14:53 Subject: Re: [PATCH] Fix regression tests on Cygwin Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0610241653020.2106%40wbgn013.biozentrum.uni-wuerzburg.de In-Reply-To: <11616320733093-git-send-email-hjemli@gmail.com> ``` Hi, On Mon, 23 Oct 2006, Lars Hjemli wrote: > On Cygwin, "make test" failes due to missing ".exe" a couple of places. Last time I made "test" on cygwin, it did not complain. "../git" works perfectly here. Ciao, Dscho ``` ## Junio C Hamano, 2006-10-25 04:40 Subject: Re: [PATCH] Fix regression tests on Cygwin Message-ID: <7vwt6pdn46.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vwt6pdn46.fsf%40assigned-by-dhcp.cox.net In-Reply-To: ``` Johannes Schindelin writes: > On Mon, 23 Oct 2006, Lars Hjemli wrote: > >> On Cygwin, "make test" failes due to missing ".exe" a couple of places. > > Last time I made "test" on cygwin, it did not complain. Same here (W2k, fairly up-to-date git, installed on local NTFS disk). ``` ## Junio C Hamano, 2006-10-25 04:50 Subject: Re: [PATCH] Fix regression tests on Cygwin Message-ID: <7vods1dmnu.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vods1dmnu.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <7vwt6pdn46.fsf@assigned-by-dhcp.cox.net> ``` Junio C Hamano writes: > Johannes Schindelin writes: > >> On Mon, 23 Oct 2006, Lars Hjemli wrote: >> >>> On Cygwin, "make test" failes due to missing ".exe" a couple of places. >> >> Last time I made "test" on cygwin, it did not complain. > > Same here (W2k, fairly up-to-date git, installed on local NTFS > disk). ... and more importantly, with fairly up-to-date Cygwin. ``` ## Lars Hjemli, 2006-10-25 06:39 Subject: Re: [PATCH] Fix regression tests on Cygwin Message-ID: <8c5c35580610242339r7c2501dh7165dea49965632b@mail.gmail.com> URL: https://gitlist.dev/e/8c5c35580610242339r7c2501dh7165dea49965632b%40mail.gmail.com In-Reply-To: <7vods1dmnu.fsf@assigned-by-dhcp.cox.net> ``` On 10/25/06, Junio C Hamano wrote: > Junio C Hamano writes: > > > Johannes Schindelin writes: > > > >> On Mon, 23 Oct 2006, Lars Hjemli wrote: > >> > >>> On Cygwin, "make test" failes due to missing ".exe" a couple of places. > >> > >> Last time I made "test" on cygwin, it did not complain. > > > > Same here (W2k, fairly up-to-date git, installed on local NTFS > > disk). Well, then it's probably my cygwin-environment that is broken (make test used to work for me too...) Sorry for the noise -- ```