# [PATCH] i18n: mark more bundle.c strings for translation 2 messages from 2023-07-13 to 2023-07-13. Participants: D. Ben Knoble via GitGitGadget, Junio C Hamano. Thread: https://gitlist.dev/t/59983 ## D. Ben Knoble via GitGitGadget, 2023-07-13 22:01 Subject: [PATCH] i18n: mark more bundle.c strings for translation Message-ID: URL: https://gitlist.dev/e/pull.1550.git.1689285683013.gitgitgadget%40gmail.com ``` From: "D. Ben Knoble" These two messages were introduced in 8ba221e245 (bundle: output hash information in 'verify', 2022-03-22) and 105c6f14ad (bundle: parse filter capability, 2022-03-09) but never for translation. Signed-off-by: D. Ben Knoble --- i18n: mark more bundle.c strings for translation I noticed that git bundle output contained some untranslated messages for LC_ALL=fr_FR.UTF-8; in order to add translations for these messages, they need to be marked for translation. Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1550%2Fbenknoble%2Fbundle-translations-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1550/benknoble/bundle-translations-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/1550 bundle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bundle.c b/bundle.c index 8d5936c4212..a9744da255c 100644 --- a/bundle.c +++ b/bundle.c @@ -271,10 +271,10 @@ int verify_bundle(struct repository *r, list_refs(r, 0, NULL); } - printf_ln("The bundle uses this hash algorithm: %s", + printf_ln(_("The bundle uses this hash algorithm: %s"), header->hash_algo->name); if (header->filter.choice) - printf_ln("The bundle uses this filter: %s", + printf_ln(_("The bundle uses this filter: %s"), list_objects_filter_spec(&header->filter)); } cleanup: base-commit: aa9166bcc0ba654fc21f198a30647ec087f733ed -- gitgitgadget ``` ## Junio C Hamano, 2023-07-13 22:20 Subject: Re: [PATCH] i18n: mark more bundle.c strings for translation Message-ID: URL: https://gitlist.dev/e/xmqqh6q7lahl.fsf%40gitster.g In-Reply-To: ``` "D. Ben Knoble via GitGitGadget" writes: > From: "D. Ben Knoble" > > These two messages were introduced in 8ba221e245 (bundle: output hash > information in 'verify', 2022-03-22) and 105c6f14ad (bundle: parse > filter capability, 2022-03-09) but never for translation. Thanks for catching and reporting. > diff --git a/bundle.c b/bundle.c > index 8d5936c4212..a9744da255c 100644 > --- a/bundle.c > +++ b/bundle.c > @@ -271,10 +271,10 @@ int verify_bundle(struct repository *r, > list_refs(r, 0, NULL); > } > > - printf_ln("The bundle uses this hash algorithm: %s", > + printf_ln(_("The bundle uses this hash algorithm: %s"), > header->hash_algo->name); > if (header->filter.choice) > - printf_ln("The bundle uses this filter: %s", > + printf_ln(_("The bundle uses this filter: %s"), > list_objects_filter_spec(&header->filter)); Looking good. Will queue. Thanks. ```