# [PATCH] pretty: use strchr(3) in userformat_find_requirements() 1 messages from 2023-07-07 to 2023-07-07. Participants: René Scharfe. Thread: https://gitlist.dev/t/59961 ## René Scharfe, 2023-07-07 19:08 Subject: [PATCH] pretty: use strchr(3) in userformat_find_requirements() Message-ID: <108ab1a2-28f4-dd62-1f90-64f37708aa8c@web.de> URL: https://gitlist.dev/e/108ab1a2-28f4-dd62-1f90-64f37708aa8c%40web.de ``` The strbuf_expand_step() loop in userformat_find_requirements() iterates through the percent signs in the string "fmt", but we're not interested in its effect on the strbuf "dummy". Use strchr(3) instead and get rid of the strbuf that we no longer need. Suggested-by: Jeff King Signed-off-by: René Scharfe --- pretty.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pretty.c b/pretty.c index 7862be105d..d9419aa062 100644 --- a/pretty.c +++ b/pretty.c @@ -1876,14 +1876,13 @@ static size_t format_commit_item(struct strbuf *sb, /* in UTF-8 */ void userformat_find_requirements(const char *fmt, struct userformat_want *w) { - struct strbuf dummy = STRBUF_INIT; - if (!fmt) { if (!user_format) return; fmt = user_format; } - while (strbuf_expand_step(&dummy, &fmt)) { + while ((fmt = strchr(fmt, '%'))) { + fmt++; if (skip_prefix(fmt, "%", &fmt)) continue; @@ -1903,7 +1902,6 @@ void userformat_find_requirements(const char *fmt, struct userformat_want *w) break; } } - strbuf_release(&dummy); } void repo_format_commit_message(struct repository *r, -- 2.41.0 ```