# [PATCH] pretty: avoid double negative in format_commit_item() 2 messages from 2023-07-07 to 2023-07-07. Participants: René Scharfe, Junio C Hamano. Thread: https://gitlist.dev/t/59960 ## René Scharfe, 2023-07-07 18:46 Subject: [PATCH] pretty: avoid double negative in format_commit_item() Message-ID: <8d4fcad1-5f71-4790-17ee-e9ba0a3118dc@web.de> URL: https://gitlist.dev/e/8d4fcad1-5f71-4790-17ee-e9ba0a3118dc%40web.de ``` Test for equality with no_flush, which has enough negation already. Get rid of the unnecessary parentheses while at it. Signed-off-by: René Scharfe --- pretty.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pretty.c b/pretty.c index 7862be105d..81cdc9f2cd 100644 --- a/pretty.c +++ b/pretty.c @@ -1855,10 +1855,10 @@ static size_t format_commit_item(struct strbuf *sb, /* in UTF-8 */ } orig_len = sb->len; - if ((context)->flush_type != no_flush) - consumed = format_and_pad_commit(sb, placeholder, context); - else + if (context->flush_type == no_flush) consumed = format_commit_one(sb, placeholder, context); + else + consumed = format_and_pad_commit(sb, placeholder, context); if (magic == NO_MAGIC) return consumed; -- 2.41.0 ``` ## Junio C Hamano, 2023-07-07 19:06 Subject: Re: [PATCH] pretty: avoid double negative in format_commit_item() Message-ID: URL: https://gitlist.dev/e/xmqqcz138rsy.fsf%40gitster.g In-Reply-To: <8d4fcad1-5f71-4790-17ee-e9ba0a3118dc@web.de> ``` René Scharfe writes: > Test for equality with no_flush, which has enough negation already. Get > rid of the unnecessary parentheses while at it. Makes sense. This double negation was with us since a5752342 (pretty: support padding placeholders, %< %> and %><, 2013-04-19), that is more than 10 years old ;-) Will queue. Thanks. > Signed-off-by: René Scharfe > --- > pretty.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/pretty.c b/pretty.c > index 7862be105d..81cdc9f2cd 100644 > --- a/pretty.c > +++ b/pretty.c > @@ -1855,10 +1855,10 @@ static size_t format_commit_item(struct strbuf *sb, /* in UTF-8 */ > } > > orig_len = sb->len; > - if ((context)->flush_type != no_flush) > - consumed = format_and_pad_commit(sb, placeholder, context); > - else > + if (context->flush_type == no_flush) > consumed = format_commit_one(sb, placeholder, context); > + else > + consumed = format_and_pad_commit(sb, placeholder, context); > if (magic == NO_MAGIC) > return consumed; > > -- > 2.41.0 ```