# [PATCH] sequencer: remove pointless rollback_lock_file() 2 messages from 2023-03-23 to 2023-03-24. Participants: Oswald Buddenhagen, Junio C Hamano. Thread: https://gitlist.dev/t/59456 ## Oswald Buddenhagen, 2023-03-23 16:22 Subject: [PATCH] sequencer: remove pointless rollback_lock_file() Message-ID: <20230323162235.995529-1-oswald.buddenhagen@gmx.de> URL: https://gitlist.dev/e/20230323162235.995529-1-oswald.buddenhagen%40gmx.de ``` The file is gone even if commit_lock_file() fails. Signed-off-by: Oswald Buddenhagen --- sequencer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sequencer.c b/sequencer.c index 3be23d7ca2..2da9b9f890 100644 --- a/sequencer.c +++ b/sequencer.c @@ -3676,7 +3676,6 @@ static int safe_append(const char *filename, const char *fmt, ...) } if (commit_lock_file(&lock) < 0) { strbuf_release(&buf); - rollback_lock_file(&lock); return error(_("failed to finalize '%s'"), filename); } -- 2.40.0.152.g15d061e6df ``` ## Junio C Hamano, 2023-03-24 14:51 Subject: Re: [PATCH] sequencer: remove pointless rollback_lock_file() Message-ID: URL: https://gitlist.dev/e/xmqq8rfm5hk7.fsf%40gitster.g In-Reply-To: <20230323162235.995529-1-oswald.buddenhagen@gmx.de> ``` Oswald Buddenhagen writes: > The file is gone even if commit_lock_file() fails. Good spotting. I glanced over hits from "git grep -A6 commit_lock_file \*.c" to see if there is a similar mistake, but this seems to be the only one. Will queue. Thanks. > Signed-off-by: Oswald Buddenhagen > --- > sequencer.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sequencer.c b/sequencer.c > index 3be23d7ca2..2da9b9f890 100644 > --- a/sequencer.c > +++ b/sequencer.c > @@ -3676,7 +3676,6 @@ static int safe_append(const char *filename, const char *fmt, ...) > } > if (commit_lock_file(&lock) < 0) { > strbuf_release(&buf); > - rollback_lock_file(&lock); > return error(_("failed to finalize '%s'"), filename); > } ```