threads / patch / 5918

patch, 2 partsMake write_sha1_file_prepare() static

Subject: [PATCH 2/2] Make write_sha1_file_prepare() static

## tl;dr

One message between Oct 14, 2006 and Oct 14, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Rene Scharfe· Oct 14, 2006, 10:45 UTC · lore

There are no callers of write_sha1_file_prepare() left outside of sha1_file.c, so make it static.

---
 cache.h     |    6 ------
 sha1_file.c |    9 +++------
 2 files changed, 3 insertions(+), 12 deletions(-)
Show changes to 2 files +3 −12

cache.h, sha1_file.c

diff --git a/cache.h b/cache.h
index aa3a562..c354701 100644
--- a/cache.h
+++ b/cache.h
@@ -247,12 +247,6 @@ extern void * unpack_sha1_file(void *map
 extern void * read_sha1_file(const unsigned char *sha1, char *type, unsigned long *size);
 extern int hash_sha1_file(void *buf, unsigned long len, const char *type, unsigned char *sha1);
 extern int write_sha1_file(void *buf, unsigned long len, const char *type, unsigned char *return_sha1);
-extern char *write_sha1_file_prepare(void *buf,
-				     unsigned long len,
-				     const char *type,
-				     unsigned char *sha1,
-				     unsigned char *hdr,
-				     int *hdrlen);
 
 extern int check_sha1_signature(const unsigned char *sha1, void *buf, unsigned long size, const char *type);
 
diff --git a/sha1_file.c b/sha1_file.c
index 6c64ec4..d111be7 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -1347,12 +1347,9 @@ void *read_object_with_reference(const u
 	}
 }
 
-char *write_sha1_file_prepare(void *buf,
-			      unsigned long len,
-			      const char *type,
-			      unsigned char *sha1,
-			      unsigned char *hdr,
-			      int *hdrlen)
+static char *write_sha1_file_prepare(void *buf, unsigned long len,
+                                     const char *type, unsigned char *sha1,
+                                     unsigned char *hdr, int *hdrlen)
 {
 	SHA_CTX c;
 
-- 
1.4.3.rc2.gdce3

← back to recent threads