PROBLEM: "git pull -v" fails with exit code denoting a submodule syntax error

--

Thank you for filling out a Git bug report! Please answer the following questions to help us understand your issue.

What did you do before the bug happened? (Steps to reproduce your issue)

I upgraded Git to version 2.38.1.windows.1

What did you expect to happen? (Expected behavior)

I expected "git pull -v" to simply work and exit correctly without telling me the syntax of "git submodule".

What happened instead? (Actual behavior)

This:

What's different between what you expected and what actually happened?

The text I quoted above, and an exit with error code.

Anything else you want to add:

The '-v' parameter is used by TortoiseGit and GitExtensions, which now both croak on pulling.

Please review the rest of the bug report below. You can delete any lines you don't wish to share.

[System Info] git version: git version 2.38.1.windows.1 cpu: x86_64 built from commit: b85c8f604d375d4d773a36842964e8a7ec056aae sizeof-long: 4 sizeof-size_t: 8 shell-path: /bin/sh feature: fsmonitor--daemon uname: Windows 10.0 19044 compiler info: gnuc: 12.2 libc info: no libc information available $SHELL (typically, interactive shell): <unset>

[Enabled Hooks]

Canon Production Printing Germany GmbH & Co. KG P.O. Box 1260, 85581 Poing Siemensallee 2, 85586 Poing Germany | www.cpp.canon Canon Production Printing Germany GmbH & Co. KG. The company is a limited partnership with its registered office in Poing Trade Register HRA 100955 (Amtsgericht M?nchen) - WEEE-Reg. - No. DE 888 05 443

General Partner: Canon Production Printing Gesch?ftsf?hrungsgesellschaft mbH Registered Office: Poing Trade Register HRB 206480 (Amtsgericht M?nchen) Executive Officer: Johann Meyer ?

This message and attachment(s) are intended solely for use by the addressee and may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable law. If you are not the intended recipient or agent thereof responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by telephone or with a 'reply' message and delete the message and its attachment(s), if any, from your system(s). Thank you for your co-operation. 

On December 16, 2022 3:28 AM, Nemmaier, Christoph wrote:

Hi Christoph,

I have gone back to git 2.36.0 and cannot find support for the -v submodule command parameter. At what version did this last work for you? Do you have a git alias in effect that might be adding -v? --Randall

<rsbecker@nexbridge.com> writes:

I suspect it is the same issue as the one that triggered

  https://lore.kernel.org/git/f805f2da-a7e1-9fde-cc0a-04a30f79c9af@cs-ware.de/

which came out recently?

Hi,

this indeed seems to be the same problem. As I already added, my problem occurs when submodule recursion is set in .gitconfig. 

Canon Production Printing Germany GmbH & Co. KG P.O. Box 1260, 85581 Poing Siemensallee 2, 85586 Poing Germany | www.cpp.canon Canon Production Printing Germany GmbH & Co. KG. The company is a limited partnership with its registered office in Poing Trade Register HRA 100955 (Amtsgericht München) - WEEE-Reg. - No. DE 888 05 443

General Partner: Canon Production Printing Geschäftsführungsgesellschaft mbH Registered Office: Poing
Trade Register HRB 206480 (Amtsgericht München) 
Executive Officer: Johann Meyer
  

This message and attachment(s) are intended solely for use by the addressee and may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable law. If you are not the intended recipient or agent thereof responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by telephone or with a 'reply' message and delete the message and its attachment(s), if any, from your system(s). Thank you for your co-operation. 
-----Ursprüngliche Nachricht-----
Von: Junio C Hamano <jch2355@gmail.com> Im Auftrag von Junio C Hamano
Gesendet: Freitag, 16. Dezember 2022 11:17
An: rsbecker@nexbridge.com
Cc: Nemmaier, Christoph <christoph.nemmaier@cpp.canon>; git@vger.kernel.org
Betreff: Re: PROBLEM: "git pull -v" fails with exit code denoting a submodule syntax error

<rsbecker@nexbridge.com> writes:

I suspect it is the same issue as the one that triggered

  https://lore.kernel.org/git/f805f2da-a7e1-9fde-cc0a-04a30f79c9af@cs-ware.de/

which came out recently?

On December 16, 2022 5:17 AM, Junio C Hamano wrote:

https://lore.kernel.org/git/f805f2da-a7e1-9fde-cc0a-04a30f79c9af@cs-ware.de/

If that is the case, perhaps the -v needs to be documented in the online help if/when this condition is fixed.

Good morning,

it pretty sure is. The doc goes like:

Intentionally or not, git-submodule is not listed.

Anyway, I think the doc is correct, as git submodule doesn't know '-v'. So either the internal call should drop '-v', or 'submodule' should ignore it.

Ciao, THX, Christoph

Canon Production Printing Germany GmbH & Co. KG P.O. Box 1260, 85581 Poing Siemensallee 2, 85586 Poing Germany | www.cpp.canon Canon Production Printing Germany GmbH & Co. KG. The company is a limited partnership with its registered office in Poing Trade Register HRA 100955 (Amtsgericht M?nchen) - WEEE-Reg. - No. DE 888 05 443

General Partner: Canon Production Printing Gesch?ftsf?hrungsgesellschaft mbH Registered Office: Poing Trade Register HRB 206480 (Amtsgericht M?nchen) Executive Officer: Johann Meyer ?

This message and attachment(s) are intended solely for use by the addressee and may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable law. If you are not the intended recipient or agent thereof responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by telephone or with a 'reply' message and delete the message and its attachment(s), if any, from your system(s). Thank you for your co-operation. 

"Nemmaier, Christoph" <christoph.nemmaier@cpp.canon> writes:

Yes, <f805f2da-a7e1-9fde-cc0a-04a30f79c9af@cs-ware.de> cited above is exactly about doing that.

The resulting 6f65f847 (submodule: accept -v for the update command, 2022-12-10) is about to hit 'next'.

Great, THX.

Canon Production Printing Germany GmbH & Co. KG P.O. Box 1260, 85581 Poing Siemensallee 2, 85586 Poing Germany | www.cpp.canon Canon Production Printing Germany GmbH & Co. KG. The company is a limited partnership with its registered office in Poing Trade Register HRA 100955 (Amtsgericht München) - WEEE-Reg. - No. DE 888 05 443

General Partner: Canon Production Printing Geschäftsführungsgesellschaft mbH Registered Office: Poing
Trade Register HRB 206480 (Amtsgericht München) 
Executive Officer: Johann Meyer
  

This message and attachment(s) are intended solely for use by the addressee and may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable law. If you are not the intended recipient or agent thereof responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by telephone or with a 'reply' message and delete the message and its attachment(s), if any, from your system(s). Thank you for your co-operation. 
-----Ursprüngliche Nachricht-----
Von: Junio C Hamano <jch2355@gmail.com> Im Auftrag von Junio C Hamano
Gesendet: Dienstag, 20. Dezember 2022 00:27
An: Nemmaier, Christoph <christoph.nemmaier@cpp.canon>
Cc: rsbecker@nexbridge.com; git@vger.kernel.org
Betreff: Re: AW: PROBLEM: "git pull -v" fails with exit code denoting a submodule syntax error

"Nemmaier, Christoph" <christoph.nemmaier@cpp.canon> writes:

Yes, <f805f2da-a7e1-9fde-cc0a-04a30f79c9af@cs-ware.de> cited above is exactly about doing that.

The resulting 6f65f847 (submodule: accept -v for the update command, 2022-12-10) is about to hit 'next'.

Hi,

no alias - the command is used by TortoiseSVN, like in:

git.exe pull --progress -v --no-rebase "origin" From gitlab.ops.oce.net:nemmaiec/cpposatest = [up to date] master -> origin/master Already up to date. usage: git submodule [--quiet] [--cached] or: git submodule [--quiet] add [-b <branch>] [-f|--force] [--name <name>] [--reference <repository>] [--] <repository> [<path>] or: git submodule [--quiet] status [--cached] [--recursive] [--] [<path>...] or: git submodule [--quiet] init [--] [<path>...] or: git submodule [--quiet] deinit [-f|--force] (--all| [--] <path>...) or: git submodule [--quiet] update [--init [--filter=<filter-spec>]] [--remote] [-N|--no-fetch] [-f|--force] [--checkout|--merge|--rebase] [--[no-]recommend-shallow] [--reference <repository>] [--recursive] [--[no-]single-branch] [--] [<path>...] or: git submodule [--quiet] set-branch (--default|--branch <branch>) [--] <path> or: git submodule [--quiet] set-url [--] <path> <newurl> or: git submodule [--quiet] summary [--cached|--files] [--summary-limit <n>] [commit] [--] [<path>...] or: git submodule [--quiet] foreach [--recursive] <command> or: git submodule [--quiet] sync [--recursive] [--] [<path>...] or: git submodule [--quiet] absorbgitdirs [--] [<path>...]

I verified that the -v parameter is the culprit. Today I also found out that this only happens if .gitconfig contains a [submodule] section setting "recurse = true".

Meanwhile a colleague of mine stumbled over another problem that (he claims) was not there until he upgraded git: GitExtensions uses "--jobs=0", which does not work anymore. But, of course, that's obviously a GitExtensions problem, just never having showed up before.

Christoph

git did not exit cleanly (exit code 1) (3610 ms @ 16.12.2022 11:33:35)

Canon Production Printing Germany GmbH & Co. KG P.O. Box 1260, 85581 Poing Siemensallee 2, 85586 Poing Germany | www.cpp.canon Canon Production Printing Germany GmbH & Co. KG. The company is a limited partnership with its registered office in Poing Trade Register HRA 100955 (Amtsgericht München) - WEEE-Reg. - No. DE 888 05 443

General Partner: Canon Production Printing Geschäftsführungsgesellschaft mbH Registered Office: Poing
Trade Register HRB 206480 (Amtsgericht München) 
Executive Officer: Johann Meyer
  

This message and attachment(s) are intended solely for use by the addressee and may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable law. If you are not the intended recipient or agent thereof responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by telephone or with a 'reply' message and delete the message and its attachment(s), if any, from your system(s). Thank you for your co-operation. 
-----Ursprüngliche Nachricht-----
Von: rsbecker@nexbridge.com <rsbecker@nexbridge.com> 
Gesendet: Freitag, 16. Dezember 2022 09:42
An: Nemmaier, Christoph <christoph.nemmaier@cpp.canon>; git@vger.kernel.org
Betreff: RE: PROBLEM: "git pull -v" fails with exit code denoting a submodule syntax error

On December 16, 2022 3:28 AM, Nemmaier, Christoph wrote:

Hi Christoph,

I have gone back to git 2.36.0 and cannot find support for the -v submodule command parameter. At what version did this last work for you? Do you have a git alias in effect that might be adding -v? --Randall

Oh, I overlooked the question for the git version: As contained in my first mail, it is 2.38.1.windows.1.

I hear from colleagues tells me that 2.23 is working OK. I intend to verify this.

Canon Production Printing Germany GmbH & Co. KG P.O. Box 1260, 85581 Poing Siemensallee 2, 85586 Poing Germany | www.cpp.canon Canon Production Printing Germany GmbH & Co. KG. The company is a limited partnership with its registered office in Poing Trade Register HRA 100955 (Amtsgericht München) - WEEE-Reg. - No. DE 888 05 443

General Partner: Canon Production Printing Geschäftsführungsgesellschaft mbH Registered Office: Poing
Trade Register HRB 206480 (Amtsgericht München) 
Executive Officer: Johann Meyer
  

This message and attachment(s) are intended solely for use by the addressee and may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable law. If you are not the intended recipient or agent thereof responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by telephone or with a 'reply' message and delete the message and its attachment(s), if any, from your system(s). Thank you for your co-operation. 
-----Ursprüngliche Nachricht-----
Von: Nemmaier, Christoph 
Gesendet: Freitag, 16. Dezember 2022 11:43
An: rsbecker@nexbridge.com; git@vger.kernel.org
Betreff: AW: PROBLEM: "git pull -v" fails with exit code denoting a submodule syntax error

Hi,

no alias - the command is used by TortoiseSVN, like in:

git.exe pull --progress -v --no-rebase "origin" From gitlab.ops.oce.net:nemmaiec/cpposatest = [up to date] master -> origin/master Already up to date. usage: git submodule [--quiet] [--cached] or: git submodule [--quiet] add [-b <branch>] [-f|--force] [--name <name>] [--reference <repository>] [--] <repository> [<path>] or: git submodule [--quiet] status [--cached] [--recursive] [--] [<path>...] or: git submodule [--quiet] init [--] [<path>...] or: git submodule [--quiet] deinit [-f|--force] (--all| [--] <path>...) or: git submodule [--quiet] update [--init [--filter=<filter-spec>]] [--remote] [-N|--no-fetch] [-f|--force] [--checkout|--merge|--rebase] [--[no-]recommend-shallow] [--reference <repository>] [--recursive] [--[no-]single-branch] [--] [<path>...] or: git submodule [--quiet] set-branch (--default|--branch <branch>) [--] <path> or: git submodule [--quiet] set-url [--] <path> <newurl> or: git submodule [--quiet] summary [--cached|--files] [--summary-limit <n>] [commit] [--] [<path>...] or: git submodule [--quiet] foreach [--recursive] <command> or: git submodule [--quiet] sync [--recursive] [--] [<path>...] or: git submodule [--quiet] absorbgitdirs [--] [<path>...]

I verified that the -v parameter is the culprit. Today I also found out that this only happens if .gitconfig contains a [submodule] section setting "recurse = true".

Meanwhile a colleague of mine stumbled over another problem that (he claims) was not there until he upgraded git: GitExtensions uses "--jobs=0", which does not work anymore. But, of course, that's obviously a GitExtensions problem, just never having showed up before.

Christoph

git did not exit cleanly (exit code 1) (3610 ms @ 16.12.2022 11:33:35)

-----Ursprüngliche Nachricht-----
Von: rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Gesendet: Freitag, 16. Dezember 2022 09:42
An: Nemmaier, Christoph <christoph.nemmaier@cpp.canon>; git@vger.kernel.org
Betreff: RE: PROBLEM: "git pull -v" fails with exit code denoting a submodule syntax error

On December 16, 2022 3:28 AM, Nemmaier, Christoph wrote:

Hi Christoph,

I have gone back to git 2.36.0 and cannot find support for the -v submodule command parameter. At what version did this last work for you? Do you have a git alias in effect that might be adding -v? --Randall