threads / patch / 58884

patchlist-objects-filter: plug pattern_list leak

Subject: [PATCH] list-objects-filter: plug pattern_list leak

## tl;dr

One message between Dec 1, 2022 and Dec 1, 2022. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

René Scharfe· Dec 1, 2022, 17:49 UTC · lore

filter_sparse_oid__init() uses add_patterns_from_blob_to_list() to populate the struct pattern_list member of struct filter_sparse_data. Release it in the complementing filter_sparse_free().

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 list-objects-filter.c | 1 +
 1 file changed, 1 insertion(+)
Show changes to list-objects-filter.c +1 −1
diff --git a/list-objects-filter.c b/list-objects-filter.c
index b9543545ca..dfc3f49f4f 100644
--- a/list-objects-filter.c
+++ b/list-objects-filter.c
@@ -514,6 +514,7 @@ static enum list_objects_filter_result filter_sparse(
 static void filter_sparse_free(void *filter_data)
 {
 	struct filter_sparse_data *d = filter_data;
+	clear_pattern_list(&d->pl);
 	free(d->array_frame);
 	free(d);
 }
--
2.30.2

← back to recent threads