threads / discuss / 58863

making use of $sm_path @ git submodule foreach —recursive

Subject: making use of $sm_path @ git submodule foreach —recursive

## tl;dr

3 messages between Nov 27, 2022 and Nov 28, 2022.

replies: 2people: 2as markdown or json

signal@dynax.at· Nov 27, 2022, 22:53 UTC · lore

Hi,

when using git submodule foreach —recursive [..] $sm_path contains only the relative part of the latest recursion. Since the command has no generic way of knowing from which recursion level it is executed any $sm_path of deeper recursion level is useless unless there is a way for the command to find out from which recursion it is called.

I suggest $sm_path should be extended to be relative to the repo from where the submodule recursion started or another variable should contain the recursive part.

Viele Grüße/Cheers, Hagen.

Ævar Arnfjörð Bjarmason· Nov 28, 2022, 12:43 UTC · re: signal@dynax.at · lore

Re: making use of $sm_path @ git submodule foreach —recursive

On Sun, Nov 27 2022, signal@dynax.at wrote:

Show 14 quoted lines

> Hi,
>
> when using 
> git submodule foreach —recursive [..] 
> $sm_path contains only the relative part of the latest
> recursion. Since the command has no generic way of knowing from which
> recursion level it is executed any $sm_path of deeper recursion level
> is useless unless there is a way for the command to find out from
> which recursion it is called.
>
> I suggest $sm_path should be extended to be relative to the repo from where the submodule recursion started or another variable should contain the recursive part.
>
> Viele Grüße/Cheers,
> Hagen.

I think it might be sensible to have a $super_prefix_sm_path or something which does what you suggest here.

But the current "$sm_path" is far from useless, it's just not useful for what you're trying to do.

When we run a command in sub1/sub2 or whatever the "$sm_path" will be "sub1", then as we cd to "sub1" it'll be "sub2".

You want "sub1/sub2" there, but a "sub2" is still useful, because we've chdir()'d to the "sub1" at that point.

So you can e.g. run 'git -C "$sm_path" log' in your 'foreach', or another command that expects to get the *relative* submodule path.

If we simply changed how "$sm_path" works that would break, and if we "fixed" that by not chdir()-ing from the super-project we'd break even more things, as e.g.:

	git submodule foreach 'git pull'

Or whatever wouldn't behave as you'd expect.

signal@dynax.at· Nov 28, 2022, 14:18 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: making use of $sm_path @ git submodule foreach —recursive

Oh, thanks! I didn’t notice that it chdir’ed into the submodule folder! Then clearly this is the relation I was looking for! Thanks! sorry for the noise!

Show 42 quoted lines

> On 28.11.2022, at 13:43, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> 
> 
> On Sun, Nov 27 2022, signal@dynax.at wrote:
> 
>> Hi,
>> 
>> when using 
>> git submodule foreach —recursive [..] 
>> $sm_path contains only the relative part of the latest
>> recursion. Since the command has no generic way of knowing from which
>> recursion level it is executed any $sm_path of deeper recursion level
>> is useless unless there is a way for the command to find out from
>> which recursion it is called.
>> 
>> I suggest $sm_path should be extended to be relative to the repo from where the submodule recursion started or another variable should contain the recursive part.
>> 
>> Viele Grüße/Cheers,
>> Hagen.
> 
> I think it might be sensible to have a $super_prefix_sm_path or
> something which does what you suggest here.
> 
> But the current "$sm_path" is far from useless, it's just not useful for
> what you're trying to do.
> 
> When we run a command in sub1/sub2 or whatever the "$sm_path" will be
> "sub1", then as we cd to "sub1" it'll be "sub2".
> 
> You want "sub1/sub2" there, but a "sub2" is still useful, because we've
> chdir()'d to the "sub1" at that point.
> 
> So you can e.g. run 'git -C "$sm_path" log' in your 'foreach', or
> another command that expects to get the *relative* submodule path.
> 
> If we simply changed how "$sm_path" works that would break, and if we
> "fixed" that by not chdir()-ing from the super-project we'd break even
> more things, as e.g.:
> 
> 	git submodule foreach 'git pull'
> 
> Or whatever wouldn't behave as you'd expect.