# [PATCH] builtin: submodule--helper: Add allocation check of module_cb structure objects may be helpful in case of allocation failure 3 messages from 2022-11-22 to 2022-11-22. Participants: Li kunyu, Junio C Hamano, Bagas Sanjaya. Thread: https://gitlist.dev/t/58836 ## Li kunyu, 2022-11-22 03:17 Subject: [PATCH] builtin: submodule--helper: Add allocation check of module_cb structure objects may be helpful in case of allocation failure Message-ID: <20221122031739.3440-1-kunyu@nfschina.com> URL: https://gitlist.dev/e/20221122031739.3440-1-kunyu%40nfschina.com ``` The purpose of using temp is unknown, but adding an allocation failure report should be helpful. Signed-off-by: Li kunyu --- builtin/submodule--helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index b63f420ece..2e379623ea 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -1077,6 +1077,9 @@ static void submodule_summary_callback(struct diff_queue_struct *q, if (!S_ISGITLINK(p->one->mode) && !S_ISGITLINK(p->two->mode)) continue; temp = (struct module_cb*)malloc(sizeof(struct module_cb)); + if (!temp) + BUG("The module_cb structure object fails to be allocated and the program may terminate abnormally"); + temp->mod_src = p->one->mode; temp->mod_dst = p->two->mode; temp->oid_src = p->one->oid; -- 2.18.2 ``` ## Junio C Hamano, 2022-11-22 04:22 Subject: Re: [PATCH] builtin: submodule--helper: Add allocation check of module_cb structure objects may be helpful in case of allocation failure Message-ID: URL: https://gitlist.dev/e/xmqqh6yrsjmu.fsf%40gitster.g In-Reply-To: <20221122031739.3440-1-kunyu@nfschina.com> ``` Li kunyu writes: > The purpose of using temp is unknown, but adding an allocation failure > report should be helpful. Yuck. Use of xmalloc() may be more appropriate. Use of BUG() in a context like this is never the right thing to do. BUG() is reserved for cases where the condition should NEVER hold true in a correctly written program, and even for a correctly written program, malloc() can fail after you allocated too much memory from the heap. > > Signed-off-by: Li kunyu > --- > builtin/submodule--helper.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c > index b63f420ece..2e379623ea 100644 > --- a/builtin/submodule--helper.c > +++ b/builtin/submodule--helper.c > @@ -1077,6 +1077,9 @@ static void submodule_summary_callback(struct diff_queue_struct *q, > if (!S_ISGITLINK(p->one->mode) && !S_ISGITLINK(p->two->mode)) > continue; > temp = (struct module_cb*)malloc(sizeof(struct module_cb)); > + if (!temp) > + BUG("The module_cb structure object fails to be allocated and the program may terminate abnormally"); > + > temp->mod_src = p->one->mode; > temp->mod_dst = p->two->mode; > temp->oid_src = p->one->oid; ``` ## Bagas Sanjaya, 2022-11-22 08:08 Subject: Re: [PATCH] builtin: submodule--helper: Add allocation check of module_cb structure objects may be helpful in case of allocation failure Message-ID: <6c81f4b0-065f-01db-09ef-6ad9e3b0b39c@gmail.com> URL: https://gitlist.dev/e/6c81f4b0-065f-01db-09ef-6ad9e3b0b39c%40gmail.com In-Reply-To: <20221122031739.3440-1-kunyu@nfschina.com> ``` On 11/22/22 10:17, Li kunyu wrote: > The purpose of using temp is unknown, but adding an allocation failure > report should be helpful. > Don't you understand the code? > Signed-off-by: Li kunyu > --- > builtin/submodule--helper.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c > index b63f420ece..2e379623ea 100644 > --- a/builtin/submodule--helper.c > +++ b/builtin/submodule--helper.c > @@ -1077,6 +1077,9 @@ static void submodule_summary_callback(struct diff_queue_struct *q, > if (!S_ISGITLINK(p->one->mode) && !S_ISGITLINK(p->two->mode)) > continue; > temp = (struct module_cb*)malloc(sizeof(struct module_cb)); > + if (!temp) > + BUG("The module_cb structure object fails to be allocated and the program may terminate abnormally"); > + Why do you check whenever allocating temp is successful? -- An old man doll... just what I always wanted! - Clara ```