# [PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2

3 messages from 2006-10-11 to 2006-10-11. Participants: Luben Tuikov, Junio C Hamano.
Thread: https://gitlist.dev/t/5881

## Luben Tuikov, 2006-10-11 02:09

Subject: [PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2
Message-ID: <20061011020903.63831.qmail@web31812.mail.mud.yahoo.com>
URL: https://gitlist.dev/e/20061011020903.63831.qmail%40web31812.mail.mud.yahoo.com

```
Commit eeef88cd2 introduced $group_size which
inverted the meaning of $current_color.

Normally we start with white (same as background) color
for the zebra coloring, and flip to dark shade only when
another commit changed some lines of the file.  (Thus
if there are no changes, the file appears black on white.)

Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 173f521..77063f0 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2583,7 +2583,7 @@ sub git_blame2 {
 	git_print_page_path($file_name, $ftype, $hash_base);
 	my @rev_color = (qw(light2 dark2));
 	my $num_colors = scalar(@rev_color);
-	my $current_color = 0;
+	my $current_color = 1;
 	my $last_rev;
 	print <<HTML;
 <div class="page_body">
-- 
1.4.3.rc2.gd2a59

```

## Junio C Hamano, 2006-10-11 04:45

Subject: Re: [PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2
Message-ID: <7vk637xxxr.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vk637xxxr.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <20061011020903.63831.qmail@web31812.mail.mud.yahoo.com>

```
Luben Tuikov <ltuikov@yahoo.com> writes:

> Commit eeef88cd2 introduced $group_size which
> inverted the meaning of $current_color.
>
> Normally we start with white (same as background) color
> for the zebra coloring, and flip to dark shade only when
> another commit changed some lines of the file.  (Thus
> if there are no changes, the file appears black on white.)

I do not have much preference either way, but it was done more
or less deliberately to match what you did with 6dd36ac.

```

## Luben Tuikov, 2006-10-11 07:21

Subject: Re: [PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2
Message-ID: <20061011072126.12959.qmail@web31805.mail.mud.yahoo.com>
URL: https://gitlist.dev/e/20061011072126.12959.qmail%40web31805.mail.mud.yahoo.com
In-Reply-To: <7vk637xxxr.fsf@assigned-by-dhcp.cox.net>

```
--- Junio C Hamano <junkio@cox.net> wrote:
> I do not have much preference either way, but it was done more
> or less deliberately to match what you did with 6dd36ac.

Sorry, I didn't mean to introduce the apparent inconsisteny.
The 6dd36ac touches alternate "active" shading, and blame
only shows the contents, albeit with the commit-8 and block
coloring.

    Luben

```