threads / patch / 5871

patchAdd --dry-run option to git-send-email

Subject: [PATCH] Add --dry-run option to git-send-email

## tl;dr

3 messages between Oct 10, 2006 and Oct 10, 2006. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Matthew Wilcox· Oct 10, 2006, 14:58 UTC · lore

Add a --dry-run option to git-send-email due to having made too many mistakes with it in the past week. I like having a safety catch on my machine gun.

Signed-off-by: Matthew @ilcox <matthew@wil.cx>

--- /usr/bin/git-send-email 2006-07-29 09:52:13.000000000 -0600 +++ ./git-send-email.perl 2006-10-10 08:46:13.000000000 -0600

Show changes to diff +6 −2
@@ -40,7 +40,8 @@
 	$initial_reply_to,$initial_subject,@files,$from,$compose,$time);
 
 # Behavior modification variables
-my ($chain_reply_to, $quiet, $suppress_from, $no_signed_off_cc) = (1, 0, 0, 0);
+my ($chain_reply_to, $quiet, $suppress_from, $no_signed_off_cc,
+	$dry_run) = (1, 0, 0, 0, 0);
 my $smtp_server;
 
 # Example reply to:
@@ -63,6 +64,7 @@
 		    "quiet" => \$quiet,
 		    "suppress-from" => \$suppress_from,
 		    "no-signed-off-cc|no-signed-off-by-cc" => \$no_signed_off_cc,
+		    "dry-run" => \$dry_run,
 	 );
 
 # Verify the user input
@@ -395,7 +397,9 @@
 		$header .= "References: $references\n";
 	}
 
-	if ($smtp_server =~ m#^/#) {
+	if ($dry_run) {
+		# We don't want to send the email.
+	} elsif ($smtp_server =~ m#^/#) {
 		my $pid = open my $sm, '|-';
 		defined $pid or die $!;
 		if (!$pid) {
Junio C Hamano· Oct 10, 2006, 17:44 UTC · re: Matthew Wilcox · lore

Re: [PATCH] Add --dry-run option to git-send-email

Matthew Wilcox <matthew@wil.cx> writes:
Show 5 quoted lines
> Add a --dry-run option to git-send-email due to having made too many
> mistakes with it in the past week.  I like having a safety catch on my
> machine gun.
>
> Signed-off-by: Matthew @ilcox <matthew@wil.cx>
Good.

When I have to look into other people's issues with send-email, I used to say "--smtp-server=/var/tmp/send" which is this script:

        #!/bin/sh
        for i
        do
                echo "arg $i"
        done
        sed -e 's/^/Msg: /'

I hope your patch makes the above hack unneeded (I want to see what is fed to sendmail, what goes on the header and body).

Jakub Narebski· Oct 10, 2006, 21:03 UTC · re: Matthew Wilcox · lore

Re: [PATCH] Add --dry-run option to git-send-email

Matthew Wilcox wrote:
> Add a --dry-run option to git-send-email due to having made too many
> mistakes with it in the past week.  I like having a safety catch on my
> machine gun.
+1

I'd like also for git-send-email to check if there are any patches to send, as I oftend did forgot to provide patches.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

← back to recent threads