# [PATCH] t3435: remove redundant test case 3 messages from 2022-10-10 to 2022-10-11. Participants: Phillip Wood via GitGitGadget, Junio C Hamano, Phillip Wood. Thread: https://gitlist.dev/t/58591 ## Phillip Wood via GitGitGadget, 2022-10-10 09:45 Subject: [PATCH] t3435: remove redundant test case Message-ID: URL: https://gitlist.dev/e/pull.1379.git.1665395106351.gitgitgadget%40gmail.com ``` From: Phillip Wood rebase --preserve-merges no longer exists so there is no point in carrying this failing test case. Signed-off-by: Phillip Wood --- t3435: remove redundant test case test_expect_failure was covering up an unexpected failure. Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1379%2Fphillipwood%2Fwip%2Frebase-remove-redundant-test-case-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1379/phillipwood/wip/rebase-remove-redundant-test-case-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/1379 t/t3435-rebase-gpg-sign.sh | 8 -------- 1 file changed, 8 deletions(-) diff --git a/t/t3435-rebase-gpg-sign.sh b/t/t3435-rebase-gpg-sign.sh index 5f8ba2c7399..6aa2aeb628d 100755 --- a/t/t3435-rebase-gpg-sign.sh +++ b/t/t3435-rebase-gpg-sign.sh @@ -64,14 +64,6 @@ test_rebase_gpg_sign ! true -i --no-gpg-sign test_rebase_gpg_sign ! true -i --gpg-sign --no-gpg-sign test_rebase_gpg_sign false -i --no-gpg-sign --gpg-sign -test_expect_failure 'rebase -p --no-gpg-sign override commit.gpgsign' ' - test_when_finished "git clean -f" && - git reset --hard merged && - git config commit.gpgsign true && - git rebase -p --no-gpg-sign --onto=one fork-point main && - test_must_fail git verify-commit HEAD -' - test_expect_success 'rebase -r, merge strategy, --gpg-sign will sign commit' ' git reset --hard merged && test_unconfig commit.gpgsign && base-commit: 3dcec76d9df911ed8321007b1d197c1a206dc164 -- gitgitgadget ``` ## Junio C Hamano, 2022-10-10 17:02 Subject: Re: [PATCH] t3435: remove redundant test case Message-ID: URL: https://gitlist.dev/e/xmqqpmez4no5.fsf%40gitster.g In-Reply-To: ``` "Phillip Wood via GitGitGadget" writes: > From: Phillip Wood > > rebase --preserve-merges no longer exists so there is no point in > carrying this failing test case. Looks good. I can imagine that you noticed that it was failing for a wrong reason, perhaps as part of your test-todo topic? > diff --git a/t/t3435-rebase-gpg-sign.sh b/t/t3435-rebase-gpg-sign.sh > index 5f8ba2c7399..6aa2aeb628d 100755 > --- a/t/t3435-rebase-gpg-sign.sh > +++ b/t/t3435-rebase-gpg-sign.sh > @@ -64,14 +64,6 @@ test_rebase_gpg_sign ! true -i --no-gpg-sign > test_rebase_gpg_sign ! true -i --gpg-sign --no-gpg-sign > test_rebase_gpg_sign false -i --no-gpg-sign --gpg-sign > > -test_expect_failure 'rebase -p --no-gpg-sign override commit.gpgsign' ' > - test_when_finished "git clean -f" && > - git reset --hard merged && > - git config commit.gpgsign true && > - git rebase -p --no-gpg-sign --onto=one fork-point main && > - test_must_fail git verify-commit HEAD > -' > - > test_expect_success 'rebase -r, merge strategy, --gpg-sign will sign commit' ' > git reset --hard merged && > test_unconfig commit.gpgsign && > > base-commit: 3dcec76d9df911ed8321007b1d197c1a206dc164 ``` ## Phillip Wood, 2022-10-11 15:38 Subject: Re: [PATCH] t3435: remove redundant test case Message-ID: URL: https://gitlist.dev/e/a7d32371-4224-aa2a-4b7c-5631798ff710%40dunelm.org.uk In-Reply-To: ``` Hi Junio On 10/10/2022 18:02, Junio C Hamano wrote: > "Phillip Wood via GitGitGadget" writes: > >> From: Phillip Wood >> >> rebase --preserve-merges no longer exists so there is no point in >> carrying this failing test case. > > Looks good. > > I can imagine that you noticed that it was failing for a wrong > reason, perhaps as part of your test-todo topic? Yes I noticed it when I was looking for tests to convert to test-todo. Best Wishes Phillip >> diff --git a/t/t3435-rebase-gpg-sign.sh b/t/t3435-rebase-gpg-sign.sh >> index 5f8ba2c7399..6aa2aeb628d 100755 >> --- a/t/t3435-rebase-gpg-sign.sh >> +++ b/t/t3435-rebase-gpg-sign.sh >> @@ -64,14 +64,6 @@ test_rebase_gpg_sign ! true -i --no-gpg-sign >> test_rebase_gpg_sign ! true -i --gpg-sign --no-gpg-sign >> test_rebase_gpg_sign false -i --no-gpg-sign --gpg-sign >> >> -test_expect_failure 'rebase -p --no-gpg-sign override commit.gpgsign' ' >> - test_when_finished "git clean -f" && >> - git reset --hard merged && >> - git config commit.gpgsign true && >> - git rebase -p --no-gpg-sign --onto=one fork-point main && >> - test_must_fail git verify-commit HEAD >> -' >> - >> test_expect_success 'rebase -r, merge strategy, --gpg-sign will sign commit' ' >> git reset --hard merged && >> test_unconfig commit.gpgsign && >> >> base-commit: 3dcec76d9df911ed8321007b1d197c1a206dc164 ```