threads / patch / 58526

patchpush: improve grammar of branch.autoSetupMerge advice

Subject: [PATCH] push: improve grammar of branch.autoSetupMerge advice

## tl;dr

One message between Sep 28, 2022 and Sep 28, 2022. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Alex Henrie· Sep 28, 2022, 05:58 UTC · lore

"upstream branches" is plural but "name" and "local branch" are singular. Make them all singular. And because we're talking about a hypothetical branch that doesn't exist yet, use the future tense.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
 builtin/push.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to builtin/push.c +2 −2
diff --git a/builtin/push.c b/builtin/push.c
index df0d68e599..f0329c62a2 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -169,8 +169,8 @@ static NORETURN void die_push_simple(struct branch *branch,
 	if (git_branch_track != BRANCH_TRACK_SIMPLE)
 		advice_automergesimple_maybe = _("\n"
 				 "To avoid automatically configuring "
-				 "upstream branches when their name\n"
-				 "doesn't match the local branch, see option "
+				 "an upstream branch when its name\n"
+				 "won't match the local branch, see option "
 				 "'simple' of branch.autoSetupMerge\n"
 				 "in 'git help config'.\n");
 	die(_("The upstream branch of your current branch does not match\n"
-- 
2.37.3

← back to recent threads