threads / patch / 58486

patchpack-bitmap: improve grammar of "xor chain" error message

Subject: [PATCH] pack-bitmap: improve grammar of "xor chain" error message

## tl;dr

2 messages between Sep 22, 2022 and Sep 23, 2022. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Alex Henrie· Sep 22, 2022, 02:51 UTC · lore

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
 pack-bitmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to pack-bitmap.c +1 −1

diff --git a/pack-bitmap.c b/pack-bitmap.c
index 9a208abc1f..9d5205055a 100644
--- a/pack-bitmap.c
+++ b/pack-bitmap.c
@@ -723,7 +723,7 @@ static struct stored_bitmap *lazy_bitmap_for_commit(struct bitmap_index *bitmap_
 		ALLOC_GROW(xor_items, xor_items_nr + 1, xor_items_alloc);
 
 		if (xor_items_nr + 1 >= bitmap_git->entry_count) {
-			error(_("corrupt bitmap lookup table: xor chain exceed entry count"));
+			error(_("corrupt bitmap lookup table: xor chain exceeds entry count"));
 			goto corrupt;
 		}

-- 
2.37.3

Junio C Hamano· Sep 23, 2022, 15:55 UTC · re: Alex Henrie · lore

Re: [PATCH] pack-bitmap: improve grammar of "xor chain" error message

Alex Henrie <alexhenrie24@gmail.com> writes:

Show 15 quoted lines

> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  pack-bitmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pack-bitmap.c b/pack-bitmap.c
> index 9a208abc1f..9d5205055a 100644
> --- a/pack-bitmap.c
> +++ b/pack-bitmap.c
> @@ -723,7 +723,7 @@ static struct stored_bitmap *lazy_bitmap_for_commit(struct bitmap_index *bitmap_
>  		ALLOC_GROW(xor_items, xor_items_nr + 1, xor_items_alloc);
>  
>  		if (xor_items_nr + 1 >= bitmap_git->entry_count) {
> -			error(_("corrupt bitmap lookup table: xor chain exceed entry count"));
> +			error(_("corrupt bitmap lookup table: xor chain exceeds entry count"));

Thanks. This will affect the l10n team, and the change is obviously innocuous, so let's merge it down immediately to the 'master' branch to make the life of l10n team more predictable.