threads / discuss / 58367

[Proposal] Pass additional metadata to sendemail-validate hook from git send-email

Subject: [Proposal] Pass additional metadata to sendemail-validate hook from git send-email

## tl;dr

3 messages between Aug 26, 2022 and Aug 29, 2022.

replies: 2people: 2as markdown or json

Strawbridge, Michael· Aug 26, 2022, 21:00 UTC · lore
Hi,
I was hoping to put a feature proposal forward for git send-email.

For git send-email there is a git hook, sendemail-validate which gets the body of the email that will be sent but is missing some of the metadata that git send-email has access to. I propose that we also pass the extra metadata that gets presented to the user later on via stdout such as: From, To, Cc, Subject, Date, Message-Id, X-Mailer, MIME-Version, Content-Transfer-Encoding to the git hook.

I'm willing to work on the patch but want to make sure the idea would be accepted first.

Thank you, Michael

brian m. carlson· Aug 28, 2022, 00:39 UTC · re: Strawbridge, Michael · lore

Re: [Proposal] Pass additional metadata to sendemail-validate hook from git send-emailg

On 2022-08-26 at 21:00:25, Strawbridge, Michael wrote:
> Hi,
Hey,
Show 12 quoted lines
> I was hoping to put a feature proposal forward for git send-email.
> 
> For git send-email there is a git hook, sendemail-validate which
> gets the body of the email that will be sent but is missing some
> of the metadata that git send-email has access to.  I propose that
> we also pass the extra metadata that gets presented to the user
> later on via stdout such as: From, To, Cc, Subject, Date,
> Message-Id, X-Mailer, MIME-Version, Content-Transfer-Encoding to
> the git hook.
> 
> I'm willing to work on the patch but want to make sure the idea
> would be accepted first.

I think the idea is interesting and would be willing to see a patch come to the list.

However, having said that, we typically evaluate patches, not proposals, so to see if it's actually accepted, you'd have to actually send a patch. We may find that while the idea is interesting, it turns out to be infeasible, or, for whatever reason, the patch is unsuitable.

I know that this is different from how other projects typically work, where you typically pitch an idea first and then implement, but it's what we do here.

-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA
Strawbridge, Michael· Aug 29, 2022, 15:37 UTC · re: Strawbridge, Michael · lore

Re: [Proposal] Pass additional metadata to sendemail-validate hook from git send-email

Thanks for getting back to me.  I'll write up a patch.
brian m. carlson writes:
Show 45 quoted lines
> On 2022-08-26 at 21:00:25, Strawbridge, Michael wrote:
> > Hi,
> 
> Hey,
> 
> > I was hoping to put a feature proposal forward for git 
> > send-email.
> > 
> > For git send-email there is a git hook, sendemail-validate 
> > which
> > gets the body of the email that will be sent but is missing 
> > some
> > of the metadata that git send-email has access to.  I propose 
> > that
> > we also pass the extra metadata that gets presented to the 
> > user
> > later on via stdout such as: From, To, Cc, Subject, Date,
> > Message-Id, X-Mailer, MIME-Version, Content-Transfer-Encoding 
> > to
> > the git hook.
> > 
> > I'm willing to work on the patch but want to make sure the 
> > idea
> > would be accepted first.
> 
> I think the idea is interesting and would be willing to see a 
> patch come
> to the list.
> 
> However, having said that, we typically evaluate patches, not 
> proposals,
> so to see if it's actually accepted, you'd have to actually send 
> a
> patch.  We may find that while the idea is interesting, it turns 
> out to
> be infeasible, or, for whatever reason, the patch is unsuitable.
> 
> I know that this is different from how other projects typically 
> work,
> where you typically pitch an idea first and then implement, but 
> it's
> what we do here.
> -- 
> brian m. carlson (he/him or they/them)
> Toronto, Ontario, CA

← back to recent threads