# [PATCH v2] contrib/rerere-train: avoid useless gpg sign in training 2 messages from 2022-07-19 to 2022-07-19. Participants: Celeste Liu, Junio C Hamano. Thread: https://gitlist.dev/t/58186 ## Celeste Liu, 2022-07-19 13:03 Subject: [PATCH v2] contrib/rerere-train: avoid useless gpg sign in training Message-ID: URL: https://gitlist.dev/e/PH7PR14MB5594BE1B100435DCD28C1E45CE8F9%40PH7PR14MB5594.namprd14.prod.outlook.com ``` The rerere-train script now signs all temporary commits, which is unnecessary and useless. This commit turns off gpg signing. Signed-off-by: Celeste Liu --- v2: add problem detail in commit message. contrib/rerere-train.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/rerere-train.sh b/contrib/rerere-train.sh index 26b724c8c6..bd01e430ef 100755 --- a/contrib/rerere-train.sh +++ b/contrib/rerere-train.sh @@ -75,7 +75,7 @@ do continue fi git checkout -q "$parent1^0" - if git merge $other_parents >/dev/null 2>&1 + if git merge --no-gpg-sign $other_parents >/dev/null 2>&1 then # Cleanly merges continue -- 2.37.1 ``` ## Junio C Hamano, 2022-07-19 16:26 Subject: Re: [PATCH v2] contrib/rerere-train: avoid useless gpg sign in training Message-ID: URL: https://gitlist.dev/e/xmqqzgh5ax1d.fsf%40gitster.g In-Reply-To: ``` Celeste Liu writes: > The rerere-train script now signs all temporary commits, > which is unnecessary and useless. Not for me ;-) There must be something else that is forcing it to behave that way. > This commit turns off gpg signing. > > Signed-off-by: Celeste Liu > --- > > v2: add problem detail in commit message. > > contrib/rerere-train.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/rerere-train.sh b/contrib/rerere-train.sh > index 26b724c8c6..bd01e430ef 100755 > --- a/contrib/rerere-train.sh > +++ b/contrib/rerere-train.sh > @@ -75,7 +75,7 @@ do > continue > fi > git checkout -q "$parent1^0" > - if git merge $other_parents >/dev/null 2>&1 > + if git merge --no-gpg-sign $other_parents >/dev/null 2>&1 > then > # Cleanly merges > continue ```