# "reject arguments in cone-mode that look like patterns" doesn't work in macos-12 4 messages from 2022-07-14 to 2022-07-14. Participants: fawaz ahmed0, Victoria Dye. Thread: https://gitlist.dev/t/58156 ## fawaz ahmed0, 2022-07-14 08:00 Subject: "reject arguments in cone-mode that look like patterns" doesn't work in macos-12 Message-ID: URL: https://gitlist.dev/e/BL0PR13MB427533B25CCFE6A37F7619E8F1889%40BL0PR13MB4275.namprd13.prod.outlook.com In-Reply-To: ``` Please refer: https://github.com/git/git/commit/8dd7c4739bded62175bea1f7518d993b39b51f90#commitcomment-78433458 Using patterns in cone mode should fail, but it doesn't seem to fail on macOS-12(github actions) Step to reproduce(try in macOS-12): git clone --filter=blob:none --no-checkout --depth 1 --sparse https://github.com/fawazahmed0/currency-api.git . git sparse-checkout add 'latest/*' Thanks Fawaz Ahmed ``` ## Victoria Dye, 2022-07-14 19:18 Subject: Re: "reject arguments in cone-mode that look like patterns" doesn't work in macos-12 Message-ID: <4f4d5d03-2a0d-19c1-fd2e-80ab86aa1145@github.com> URL: https://gitlist.dev/e/4f4d5d03-2a0d-19c1-fd2e-80ab86aa1145%40github.com In-Reply-To: ``` fawaz ahmed0 wrote: > Please refer: https://github.com/git/git/commit/8dd7c4739bded62175bea1f7518d993b39b51f90#commitcomment-78433458 > > > Using patterns in cone mode should fail, but it doesn't seem to fail on macOS-12(github actions) Can you confirm which version is being used on that MacOS agent? For example, you could add a call to 'git version' in the workflow and see what it prints out. I suspect that the agent may be using an older version of Git, which would mean that the sparse-checkout is initialized in *non* cone mode. For what it's worth, my local development machine is also MacOS 12 (running Git v2.37), and I'm correctly seeing the error in a cone mode sparse-checkout. > > Step to reproduce(try in macOS-12): > > git clone --filter=blob:none --no-checkout --depth 1 --sparse https://github.com/fawazahmed0/currency-api.git . > git sparse-checkout add 'latest/*' > > Thanks > Fawaz Ahmed ``` ## Victoria Dye, 2022-07-14 19:47 Subject: Re: "reject arguments in cone-mode that look like patterns" doesn't work in macos-12 Message-ID: URL: https://gitlist.dev/e/a1580785-e35c-9a2d-7fa1-c3d7fc62883b%40github.com In-Reply-To: ``` fawaz ahmed0 wrote: Hi Fawaz, Please make sure you "Reply-all" to include the mailing list in the discussion, and make sure to inline or bottom-post your replies. > I assume it's v2.37, you can reproduce it on github actions macos 12. Per the virtual environment specification [1] linked in the runner execution [2], the Git version used on these agents is 2.36.1. [1] https://github.com/actions/virtual-environments/blob/macOS-12/20220627.3/images/macos/macos-12-Readme.md [2] https://github.com/fawazahmed0/currency-api/runs/7312663698?check_suite_focus=true#step:1:11 > > My github actions workflow didn't fail, even when I was setting pattern in cone mode. > > please see: https://github.com/fawazahmed0/currency-api/actions/runs/2660320076/workflow#L31 Based on the commands you linked, combined with the fact that cone mode was not made the default until v2.37, you're setting a wildcard pattern in *non* cone mode. If you want to use cone mode in version v2.36, try running 'git sparse-checkout reapply --cone' after your clone to set the appropriate config. > > > > > From: Victoria Dye > Sent: Friday, July 15, 2022 12:48 AM > To: fawaz ahmed0 ; git@vger.kernel.org > Subject: Re: "reject arguments in cone-mode that look like patterns" doesn't work in macos-12 >   > fawaz ahmed0 wrote: >> Please refer: https://github.com/git/git/commit/8dd7c4739bded62175bea1f7518d993b39b51f90#commitcomment-78433458 >> >> >> Using patterns in cone mode should fail, but it doesn't seem to fail on macOS-12(github actions) > > Can you confirm which version is being used on that MacOS agent? For > example, you could add a call to 'git version' in the workflow and see what > it prints out. I suspect that the agent may be using an older version of > Git, which would mean that the sparse-checkout is initialized in *non* cone > mode. > > For what it's worth, my local development machine is also MacOS 12 (running > Git v2.37), and I'm correctly seeing the error in a cone mode > sparse-checkout. > >> >> Step to reproduce(try in macOS-12): >> >> git clone --filter=blob:none --no-checkout --depth 1 --sparse https://github.com/fawazahmed0/currency-api.git . >> git sparse-checkout add 'latest/*' >> >> Thanks >> Fawaz Ahmed ``` ## fawaz ahmed0, 2022-07-14 20:05 Subject: Re: "reject arguments in cone-mode that look like patterns" doesn't work in macos-12 Message-ID: URL: https://gitlist.dev/e/BL0PR13MB42753E6FEFE67713F0EB0895F1889%40BL0PR13MB4275.namprd13.prod.outlook.com In-Reply-To: ``` > Per the virtual environment specification [1] linked in the runner execution > [2], the Git version used on these agents is 2.36.1. > [1] https://github.com/actions/virtual-environments/blob/macOS-12/20220627.3/images/macos/macos-12-Readme.md > [2] https://github.com/fawazahmed0/currency-api/runs/7312663698?check_suite_focus=true#step:1:11 Sorry, I didn't know that every runner has it's own specification, I was actually referring the updated page: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-12-Readme.md#:~:text=7.84.0-,git%202.37.0,-Git%20LFS%3A%203 Maybe I should have manually checked the git version in runner, before filing this bug. Thank you for looking into this. ```