# activestate perl: Makemaker generates broken Makefiles.

2 messages from 2006-10-04 to 2006-10-06. Participants: Alex Riesen, Junio C Hamano.
Thread: https://gitlist.dev/t/5809

## Alex Riesen, 2006-10-04 11:25

Subject: activestate perl: Makemaker generates broken Makefiles.
Message-ID: <81b0412b0610040425j60d0647dk1489d02657379c13@mail.gmail.com>
URL: https://gitlist.dev/e/81b0412b0610040425j60d0647dk1489d02657379c13%40mail.gmail.com

```
Just a heads up. Makefile.PL can't be used. The attached patch removes
everything perl (sorry, but it'd help someone to get going).


commit bb0ea66746c764f665fc2c5a0f0c289fbbc7eb03
Author: Alex Riesen <raa.lkml@gmail.com>
Date:   Wed Oct 4 11:51:51 2006 +0200

    remove Git.xs

diff --git a/Makefile b/Makefile
index ee3bc72..93f93e1 100644
--- a/Makefile
+++ b/Makefile
@@ -590,8 +590,7 @@ ### Build rules
 
 all: $(ALL_PROGRAMS) $(BUILT_INS) git$X gitk gitweb/gitweb.cgi
 
-all: perl/Makefile
-	$(MAKE) -C perl
+all:
 	$(MAKE) -C templates
 
 strip: $(PROGRAMS) git$X
@@ -625,15 +624,11 @@ common-cmds.h: Documentation/git-*.txt
 	chmod +x $@+
 	mv $@+ $@
 
-$(patsubst %.perl,%,$(SCRIPT_PERL)): perl/Makefile
 $(patsubst %.perl,%,$(SCRIPT_PERL)): % : %.perl
 	rm -f $@ $@+
-	INSTLIBDIR=`$(MAKE) -C perl -s --no-print-directory instlibdir` && \
 	sed -e '1{' \
 	    -e '	s|#!.*perl|#!$(PERL_PATH_SQ)|' \
 	    -e '	h' \
-	    -e '	s=.*=use lib (split(/:/, $$ENV{GITPERLLIB} || "@@INSTLIBDIR@@"));=' \
-	    -e '	H' \
 	    -e '	x' \
 	    -e '}' \
 	    -e 's|@@INSTLIBDIR@@|'"$$INSTLIBDIR"'|g' \
@@ -766,10 +761,6 @@ XDIFF_OBJS=xdiff/xdiffi.o xdiff/xprepare
 	rm -f $@ && $(AR) rcs $@ $(XDIFF_OBJS)
 
 
-perl/Makefile: perl/Git.pm perl/Makefile.PL GIT-CFLAGS
-	(cd perl && $(PERL_PATH) Makefile.PL \
-		PREFIX='$(prefix_SQ)')
-
 doc:
 	$(MAKE) -C Documentation all
 
@@ -832,7 +823,6 @@ install: all
 	$(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexecdir_SQ)'
 	$(INSTALL) git$X gitk '$(DESTDIR_SQ)$(bindir_SQ)'
 	$(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install
-	$(MAKE) -C perl install
 	$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(GIT_PYTHON_DIR_SQ)'
 	$(INSTALL) $(PYMODULES) '$(DESTDIR_SQ)$(GIT_PYTHON_DIR_SQ)'
 	if test 'z$(bindir_SQ)' != 'z$(gitexecdir_SQ)'; \

```

## Junio C Hamano, 2006-10-06 04:57

Subject: Re: activestate perl: Makemaker generates broken Makefiles.
Message-ID: <7viriy2g8l.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7viriy2g8l.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <81b0412b0610040425j60d0647dk1489d02657379c13@mail.gmail.com>

```
"Alex Riesen" <raa.lkml@gmail.com> writes:

> Just a heads up. Makefile.PL can't be used. The attached patch removes
> everything perl (sorry, but it'd help someone to get going).

Since we do not have Git.xs anymore, wouldn't it be possible for
us to remove perl/Makefile.PL and have our own perl/Makefile
which does:

 * install Git.pm to $(prefix)/share/git-core/perl (aka GIT_PERL_DIR)

 * see if Error.pm is available on the system, and if not install
   private-Error.pm as Error.pm

to make everybody happy???

```