threads / patch / 5805

patch, 3 partsgitweb: blame: print commit8 on the leading row of a commit-block

Subject: [PATCH 0/3] gitweb: blame: print commit8 on the leading row of a commit-block

## tl;dr

2 messages between Oct 4, 2006 and Oct 4, 2006. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Luben Tuikov· Oct 4, 2006, 07:10 UTC · lore

The following set of patches implements Junio's excellent idea of printing the commit-8 only on the leading row of a commit block, as well as implementing mouse-over title of the author and the date of the commit. Thus making the output of git_blame2() less cluttered yet able to give more information should the user mouse-over the commit.

The difference is that this implementations doesn't use a "stack-like" chunk to represent each block-per-commit, thus eliminating the concern of rare but present files with 100s of 1000s of lines with only an initial commit.

     Luben

Junio C Hamano· Oct 4, 2006, 08:18 UTC · re: Luben Tuikov · lore

Re: [PATCH 0/3] gitweb: blame: print commit8 on the leading row of a commit-block

Luben Tuikov <ltuikov@yahoo.com> writes:

> The following set of patches implements Junio's excellent
> idea of printing the commit-8 only on the leading row of
> a commit block, as well as implementing mouse-over title of
> the author and the date of the commit.

By the way, by definition any idea by me on UI is sucky, not excellent.

I think this patch gives title= only to rows that happen to be at the beginning of a block, as opposed to what I placed in "next" which does it for the whole commit-8 column (and I did not have to do that for N lines because it uses rowspan to extend that column over multiple rows), so I suspect it makes "mouse-over" less useful.