threads / patch / 57965

patchcocci: retire is_null_sha1() rule

Subject: [PATCH] cocci: retire is_null_sha1() rule

## tl;dr

One message between Jun 8, 2022 and Jun 8, 2022. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Junio C Hamano· Jun 7, 2022, 21:50 UTC · lore

Since 8d4d86b0 (cache: remove null_sha1, 2019-08-18) removed the is_null_sha1() function, rewrite rules to correct callers of the function to use is_null_oid() instead has become irrelevant, as any new callers of the function will get caught by the compiler much more quickly without spending cycles on Coccinelle.

Remove these rules.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 contrib/coccinelle/object_id.cocci | 12 ------------
 1 file changed, 12 deletions(-)
Show changes to contrib/coccinelle/object_id.cocci +0 −12
diff --git a/contrib/coccinelle/object_id.cocci b/contrib/coccinelle/object_id.cocci
index ddf4f22bd7..01f8d6935b 100644
--- a/contrib/coccinelle/object_id.cocci
+++ b/contrib/coccinelle/object_id.cocci
@@ -1,15 +1,3 @@
-@@
-struct object_id OID;
-@@
-- is_null_sha1(OID.hash)
-+ is_null_oid(&OID)
-
-@@
-struct object_id *OIDPTR;
-@@
-- is_null_sha1(OIDPTR->hash)
-+ is_null_oid(OIDPTR)
-
 @@
 struct object_id OID;
 @@
-- 
2.36.1-485-g100d6d3ce6

← back to recent threads