Resizing panels in the gitk window

> Resizing panels in the gitk window leads to a error message that’s
> presented multiple times in a dialog:
>
> expected integer but got ""
> expected integer but got ""
>    while executing
> "$win sash place 0 $sash0 [lindex $s0 1]"
>    (procedure "resizeclistpanes" line 38)
>    invoked from within
> "resizeclistpanes .tf.histframe.pwclist 1834"
>    (command bound to event)
>
> Is this a known bug?

>
>
> On Thu, 5 May 2022, Christian Grün wrote:
>
> > Resizing panels in the gitk window leads to a error message that’s
> > presented multiple times in a dialog:
> >
> > expected integer but got ""
> > expected integer but got ""
> >    while executing
> > "$win sash place 0 $sash0 [lindex $s0 1]"
> >    (procedure "resizeclistpanes" line 38)
> >    invoked from within
> > "resizeclistpanes .tf.histframe.pwclist 1834"
> >    (command bound to event)
> >
> > Is this a known bug?
>
> It looks like the issue at [1]. It sadly seems like nobody ever reviewed
> or applied thos suggested patches, but there is some more off-list
> discussion at [2].
>
> > I’ll be happy to give more details.
> > Best, Christian
> >
>
> Best regards
>
> Matthias
>
> [1] https://lore.kernel.org/git/pull.1219.git.git.1645386457.gitgitgadget@gmail.com/#t
> [2] https://github.com/git/git/pull/1219#issuecomment-1113122632

> It looks like the issue at [1]. It sadly seems like nobody ever
> reviewed or applied thos suggested patches, but there is some more
> off-list discussion at [2].
>
> [1] https://lore.kernel.org/git/pull.1219.git.git.1645386457.gitgitgadget@gmail.com/#t
> [2] https://github.com/git/git/pull/1219#issuecomment-1113122632

> Junio C Hamano, <gitster@pobox.com> wrote:
>> I didn't look at it back then primarily because
>> the patches were made against a wrong history
>
> I remember looking for Paul's repository but I
> failed to find it so created the patch against
> the main git repo. Maybe I should have
> mentioned this in my message since I knew
> the documentation included that note.
>
> I am happy to rebase my patch if someone
> could point me in the right direction.

> Halil SEN <halilsen@gmail.com> writes:
> 
> > Junio C Hamano, <gitster@pobox.com> wrote:
> >> I didn't look at it back then primarily because
> >> the patches were made against a wrong history
> >
> > I remember looking for Paul's repository but I
> > failed to find it so created the patch against
> > the main git repo. Maybe I should have
> > mentioned this in my message since I knew
> > the documentation included that note.
> >
> > I am happy to rebase my patch if someone
> > could point me in the right direction.
> 
> Thanks for giving me a chance to double-check what we have in
> Documentation/SubmittingPatches is not stale:
> 
> - `gitk-git/` comes from Paul Mackerras's gitk project:
> 
> 	git://ozlabs.org/~paulus/gitk

> Matthias Aßhauer <mha1993@live.de> writes:
> 
> > It looks like the issue at [1]. It sadly seems like nobody ever
> > reviewed or applied thos suggested patches, but there is some more
> > off-list discussion at [2].
> >
> > [1] https://lore.kernel.org/git/pull.1219.git.git.1645386457.gitgitgadget@gmail.com/#t
> > [2] https://github.com/git/git/pull/1219#issuecomment-1113122632
> 
> Thanks for a pointer.
> 
> I do recall seeing [1] but I do not see anything happened on the
> thread since then.  I didn't look at it back then primarily because
> the patches were made against a wrong history (no, you do not want
> to make a gitk patch against my tree nor throw a pull request at my
> repository), and there was no way for me to pick it up.

> As Documentation/SubmittingPatches says:
> 
>     Some parts of the system have dedicated maintainers with their own
>     repositories.
>     ... 
>     Patches to these parts should be based on their trees.
> 
> Having said that, gitk has been quiescent for quite a while, and I
> wonder if Paul's been too busy for (or no longer interested in)
> maintaining it and perhaps he can use a replacement maintainer?

>
> Resizing panels in the gitk window leads to a error message that’s presented multiple times in a dialog:
>
> expected integer but got ""
> expected integer but got ""
>     while executing
> "$win sash place 0 $sash0 [lindex $s0 1]"
>     (procedure "resizeclistpanes" line 38)
>     invoked from within
> "resizeclistpanes .tf.histframe.pwclist 1834"
>     (command bound to event)
>
> Is this a known bug?
>
> I’ll be happy to give more details.
> Best, Christian
>

> -----Ursprüngliche Nachricht-----
> Von: Christian Grün <christian.gruen@gmail.com>
> Gesendet: Freitag, 6. Mai 2022 09:46
> An: git@vger.kernel.org
> Betreff: Re: Resizing panels in the gitk window
> 
> Maybe there’s a better place to address gitk? Anyone?
> Thanks  in advance, Christian

> 
> On Thu, May 5, 2022 at 9:01 AM Christian Grün <christian.gruen@gmail.com>
> wrote:
> >
> > Resizing panels in the gitk window leads to a error message that’s presented
> multiple times in a dialog:
> >
> > expected integer but got ""
> > expected integer but got ""
> >     while executing
> > "$win sash place 0 $sash0 [lindex $s0 1]"
> >     (procedure "resizeclistpanes" line 38)
> >     invoked from within
> > "resizeclistpanes .tf.histframe.pwclist 1834"
> >     (command bound to event)
> >
> > Is this a known bug?
> >
> > I’ll be happy to give more details.
> > Best, Christian
> >

>
>
>
> > -----Ursprüngliche Nachricht-----
> > Von: Christian Grün <christian.gruen@gmail.com>
> > Gesendet: Freitag, 6. Mai 2022 09:46
> > An: git@vger.kernel.org
> > Betreff: Re: Resizing panels in the gitk window
> >
> > Maybe there’s a better place to address gitk? Anyone?
> > Thanks  in advance, Christian
>
> I think it would be a good idea to at least say on which OS you're using gitk
> and which version of git is installed.
>
> Regards,
>   Stefan
>
> >
> > On Thu, May 5, 2022 at 9:01 AM Christian Grün <christian.gruen@gmail.com>
> > wrote:
> > >
> > > Resizing panels in the gitk window leads to a error message that’s presented
> > multiple times in a dialog:
> > >
> > > expected integer but got ""
> > > expected integer but got ""
> > >     while executing
> > > "$win sash place 0 $sash0 [lindex $s0 1]"
> > >     (procedure "resizeclistpanes" line 38)
> > >     invoked from within
> > > "resizeclistpanes .tf.histframe.pwclist 1834"
> > >     (command bound to event)
> > >
> > > Is this a known bug?
> > >
> > > I’ll be happy to give more details.
> > > Best, Christian
> > >

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > It seems to be related to the topic you are working on?
> 
> It indeed is related. Sorry for troubling you with the repo, I don't
> remember exactly how I failed before, thanks for sharing it.
> 
> > Again, I wonder if Paul's been too busy for (or no longer interested
> > in) maintaining it and perhaps he can use a replacement maintainer?
> 
> I guess I should rebase my patch and resubmit it nevertheless.
> I'll do it within the next few days. Now that I thought about it,
> I think I had trouble creating and e-mailing the patch to the mail
> list and the gitgitgadget was available only for the main repo.
> I shall ask for help if I fail to do so again.