threads / patch / 5782

patchCheck that a tag exists using show-ref instead of looking for the ref file.

Subject: [PATCH] Check that a tag exists using show-ref instead of looking for the ref file.

## tl;dr

4 messages between Oct 1, 2006 and Oct 3, 2006. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Christian Couder· Oct 1, 2006, 20:33 UTC · lore

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 git-tag.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to git-tag.sh +1 −1

diff --git a/git-tag.sh b/git-tag.sh
index 6463b31..a3f1819 100755
--- a/git-tag.sh
+++ b/git-tag.sh
@@ -66,7 +66,7 @@ done
 name="$1"
 [ "$name" ] || usage
 prev=0000000000000000000000000000000000000000
-if test -e "$GIT_DIR/refs/tags/$name"
+if git-show-ref --verify --quiet -- "refs/tags/$name"
 then
     test -n "$force" || die "tag '$name' already exists"
     prev=`git rev-parse "refs/tags/$name"`

-- 
1.4.2.1.gd567

Junio C Hamano· Oct 3, 2006, 09:09 UTC · re: Christian Couder · lore

Re: [PATCH] Check that a tag exists using show-ref instead of looking for the ref file.

Thanks. We also need this to avoid refetching already packed tags.

-- >8 -- [PATCH] git-fetch: do not look into $GIT_DIR/refs to see if a tag exists.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 git-fetch.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to git-fetch.sh +1 −1

diff --git a/git-fetch.sh b/git-fetch.sh
index f1522bd..e8a7668 100755
--- a/git-fetch.sh
+++ b/git-fetch.sh
@@ -417,7 +417,7 @@ case "$no_tags$tags" in
 		sed -ne 's|^\([0-9a-f]*\)[ 	]\(refs/tags/.*\)^{}$|\1 \2|p' |
 		while read sha1 name
 		do
-			test -f "$GIT_DIR/$name" && continue
+			git-show-ref --verify --quiet -- $name && continue
 			git-check-ref-format "$name" || {
 				echo >&2 "warning: tag ${name} ignored"
 				continue

-- 
1.4.2.3.gd1e9e

Christian Couder· Oct 3, 2006, 20:11 UTC · re: Junio C Hamano · lore

Re: [PATCH] Check that a tag exists using show-ref instead of looking for the ref file.

Junio C Hamano wrote:

> Thanks.  We also need this to avoid refetching already packed
> tags.

Yeah, I did a very quick check on the shell scripts and I obviously missed some places that need updates.

In fact, I couldn't resist to start implementing the deleted-refs/$frotz~ref stuff we talked about...

Christian.

Junio C Hamano· Oct 3, 2006, 20:26 UTC · re: Christian Couder · lore

Re: [PATCH] Check that a tag exists using show-ref instead of looking for the ref file.

Christian Couder <chriscool@tuxfamily.org> writes:

Show 9 quoted lines

> Junio C Hamano wrote:
>> Thanks.  We also need this to avoid refetching already packed
>> tags.
>
> Yeah, I did a very quick check on the shell scripts and I obviously missed 
> some places that need updates.
>
> In fact, I couldn't resist to start implementing the deleted-refs/$frotz~ref 
> stuff we talked about...

How would that help? We need to audit the existing scripts since they would not look under $GIT_DIR/deleted-refs currently anyway.