# [PATCH v4 1/1] Makefile: add a prerequisite to the coverage-report target

2 messages from 2022-04-15 to 2022-04-15. Participants: Elia Pinto, Junio C Hamano.
Thread: https://gitlist.dev/t/57735

## Elia Pinto, 2022-04-15 02:47

Subject: [PATCH v4 1/1] Makefile: add a prerequisite to the coverage-report target
Message-ID: <20220415024738.9239-1-gitter.spiros@gmail.com>
URL: https://gitlist.dev/e/20220415024738.9239-1-gitter.spiros%40gmail.com

```
Directly invoking make coverage-report as a target results in an error because
its prerequisites are missing,

This patch adds the compile-test prerequisite, which is run only once each time
the compile-report target is invoked. In practice, the developer may decide to
review the coverage-report results without necessarily rerunning for this
coverage-test, if it has already been run.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
This is the fourth revision of the patch. Compared to the third:

- @make -> $ (MAKE)
- drop touch coverage-test.made from the coverage-test.made target

 Makefile | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index f8bccfab5e..3740a3a4e7 100644
--- a/Makefile
+++ b/Makefile
@@ -3407,6 +3407,7 @@ coverage-clean-results:
 	$(RM) coverage-untested-functions
 	$(RM) -r cover_db/
 	$(RM) -r cover_db_html/
+	$(RM) coverage-test.made
 
 coverage-clean: coverage-clean-results
 	$(RM) $(addsuffix *.gcno,$(object_dirs))
@@ -3421,13 +3422,17 @@ coverage-compile:
 coverage-test: coverage-clean-results coverage-compile
 	$(MAKE) CFLAGS="$(COVERAGE_CFLAGS)" LDFLAGS="$(COVERAGE_LDFLAGS)" \
 		DEFAULT_TEST_TARGET=test -j1 test
+	touch coverage-test.made
+
+coverage-test.made:
+	$(MAKE) coverage-test
 
 coverage-prove: coverage-clean-results coverage-compile
 	$(MAKE) CFLAGS="$(COVERAGE_CFLAGS)" LDFLAGS="$(COVERAGE_LDFLAGS)" \
 		DEFAULT_TEST_TARGET=prove GIT_PROVE_OPTS="$(GIT_PROVE_OPTS) -j1" \
 		-j1 test
 
-coverage-report:
+coverage-report: coverage-test.made
 	$(QUIET_GCOV)for dir in $(object_dirs); do \
 		$(GCOV) $(GCOVFLAGS) --object-directory=$$dir $$dir*.c || exit; \
 	done
-- 
2.35.1


```

## Junio C Hamano, 2022-04-15 06:36

Subject: Re: [PATCH v4 1/1] Makefile: add a prerequisite to the coverage-report target
Message-ID: <xmqqczhig8fb.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqqczhig8fb.fsf%40gitster.g
In-Reply-To: <20220415024738.9239-1-gitter.spiros@gmail.com>

```
Elia Pinto <gitter.spiros@gmail.com> writes:

> Directly invoking make coverage-report as a target results in an error because
> its prerequisites are missing,

The result happens to be identical to what I already have in my tree.

Thanks for taking care of the details of dependencies.


```