threads / patch / 57636

patchcore.fsyncmethod: correctly camel-case warning message

Subject: [PATCH] core.fsyncmethod: correctly camel-case warning message

## tl;dr

One message between Mar 30, 2022 and Mar 30, 2022. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Neeraj K. Singh via GitGitGadget· Mar 30, 2022, 18:08 UTC · lore
From: Neeraj Singh <neerajsi@microsoft.com>

The warning for an unrecognized fsyncMethod was not camel-cased.

Reported-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Neeraj Singh <neerajsi@microsoft.com>
---
    core.fsyncmethod: correctly camel-case warning message
    
    The warning for an unrecognized fsyncMethod was not camel-cased.
    
    Reported-by: Jiang Xin worldhello.net@gmail.com Signed-off-by: Neeraj
    Singh neerajsi@microsoft.com
    
    ------------------------------------------------------------------------
    
    See
    https://lore.kernel.org/git/CANYiYbFjRMV-_opvFn78mq7tgtZFMrfPyDjDa+kyaZZfk_LmWQ@mail.gmail.com/
    where this was reported.
    
    This fixes a problem in ns/core-fsyncmethod. Please apply to 'master'.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1193%2Fneerajsi-msft%2Fns%2FcamelCase-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1193/neerajsi-msft/ns/camelCase-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1193
 config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to config.c +1 −1
diff --git a/config.c b/config.c
index 3c9b6b589ab..9eb0dbb448b 100644
--- a/config.c
+++ b/config.c
@@ -1695,7 +1695,7 @@ static int git_default_core_config(const char *var, const char *value, void *cb)
 
 	if (!strcmp(var, "core.fsyncobjectfiles")) {
 		if (fsync_object_files < 0)
-			warning(_("core.fsyncobjectfiles is deprecated; use core.fsync instead"));
+			warning(_("core.fsyncObjectFiles is deprecated; use core.fsync instead"));
 		fsync_object_files = git_config_bool(var, value);
 		return 0;
 	}

base-commit: 1d4f13e63720fb8eae39afa215199f7d77662dba
-- 
gitgitgadget

← back to recent threads