threads / discuss / 57535

Re: [GSOC] Interested in the project 'Unify ref-filter formats with other pretty formats'

Subject: Re: [GSOC] Interested in the project 'Unify ref-filter formats with other pretty formats'

## tl;dr

2 messages between Mar 10, 2022 and Mar 11, 2022.

replies: 1people: 1as markdown or json

Hariom verma· Mar 10, 2022, 23:22 UTC · lore

Hi Jayati,

Welcome to Git.

On Fri, Mar 11, 2022 at 12:52 AM Jayati Shrivastava <gaurijove@gmail.com> wrote:

Show 12 quoted lines

>
> Hi,
>
> I am Jayati Shrivastava, a senior undergrad at Indian Institute of
> Technology Roorkee where I am majoring in Electrical Engineering with
> minors in Computer Science. I am interested in working on the project
> 'Unify ref-filter formats with other pretty formats' under GSOC'22 and
> have been exploring Hariom's and Olga's prior work on it. I have
> previously contributed to open-source communities like Mozilla
> Firefox, Facebook's Jest, phpMyAdmin and Apache Airflow. I am very
> enthusiastic about joining the Git community and would love to
> contribute to this project under your mentorship.

Great.

> If the microproject 'Use test_path_is_* functions in test scripts' is available,
> I would like to submit a patch for it. Please let me know what you think.

Sure. You can pick this up.

> Regards,
> Jayati

Thanks, Hariom

Hariom verma· Mar 11, 2022, 21:48 UTC · lore

On Fri, Mar 11, 2022 at 9:54 PM Jayati Shrivastava <gaurijove@gmail.com> wrote:

Show 6 quoted lines

>
> For the microproject - "Use test_path_is_* functions in test scripts", is the intent
> to do away with all calls to run_command*  or to only remove those run_command*
> calls where spawning a child process is an overkill (similar to https://github.com/git/git/commit/ffcb4e94d3) ?
> If it's the latter then I am not sure how to identify such cases.
> Would be great if you could clarify it further.

Since `test_path_is_*` functions are more robust and debug-friendly. And are just wrappers around `test -(e|f|d|…)`. So, I think it's okay to use them wherever possible.

But maybe someone on the mailing list will be able to provide better and correct explanation. cc(ing) Christian and mailing list.

> Meanwhile, I'll try to work on another microproject to get familiar
> with the patch submission process.

We generally expect one microproject per student. But contributions are always welcome :)

Thanks, Hariom