threads / bug / 57495

[BUG] fetch/pull -h ABORT out of a git repo

Subject: [BUG] fetch/pull -h ABORT out of a git repo

## tl;dr

3 messages between Mar 2, 2022 and Mar 2, 2022.

replies: 2people: 2as markdown or json

lilinchao@oschina.cn· Mar 2, 2022, 10:45 UTC · lore

Hi,

When I run git fetch -h or git pull -h out side of a git repo, I can't get any help message but some bug messages:

"$ git pull -h                                                                                                                            
BUG: repo-settings.c:21: Cannot add settings for uninitialized repository
[1]    17589 abort      git pull -h

$ git pull -h
BUG: repo-settings.c:21: Cannot add settings for uninitialized repository
[1]    17737 abort      git pull -h
"

Apparently, the process aborted unexpectedly. I think this is a BUG.

This was introduced after v2.34.1, the related commits are:

5a4e0547e2386f9bf0565316d7b751fe9459898b 44c7e62e51e504c060844360fc56b613cfc1beea

-------------- lilinchao@oschina.cn

lilinchao@oschina.cn· Mar 2, 2022, 11:07 UTC · re: lilinchao@oschina.cn · lore

Re: [BUG] fetch/pull -h ABORT out of a git repo

Show 6 quoted lines

>Apparently, the process aborted unexpectedly. I think this is a BUG.
>
>This was introduced after v2.34.1, the related commits are:
>
>5a4e0547e2386f9bf0565316d7b751fe9459898b
>44c7e62e51e504c060844360fc56b613cfc1beea

Since I found more commands will abort, I think the main relevant commit is 44c7e62e [1]

[1]: https://lore.kernel.org/git/fd28be71ca47a71b224a5b08cb81f903ada6a2bd.1638806161.git.gitgitgadget@gmail.com/

Junio C Hamano· Mar 2, 2022, 19:22 UTC · re: lilinchao@oschina.cn · lore

Re: [BUG] fetch/pull -h ABORT out of a git repo

"lilinchao@oschina.cn" <lilinchao@oschina.cn> writes:

Show 12 quoted lines

>>Apparently, the process aborted unexpectedly. I think this is a BUG.
>>
>>This was introduced after v2.34.1, the related commits are:
>>
>>5a4e0547e2386f9bf0565316d7b751fe9459898b
>>44c7e62e51e504c060844360fc56b613cfc1beea
>
> Since I found more commands will abort, I think the main relevant
> commit is 44c7e62e [1]
>
> [1]:
> https://lore.kernel.org/git/fd28be71ca47a71b224a5b08cb81f903ada6a2bd.1638806161.git.gitgitgadget@gmail.com/

Thanks; I think the fix 059fda19 (checkout/fetch/pull/pack-objects: allow `-h` outside a repository, 2022-02-08) is already in the 'master/main' branch.