# [PATCH] builtin/diff.c: fix "git-diff" usage string typo

2 messages from 2022-02-02 to 2022-02-02. Participants: Shaoxuan Yuan, Christian Couder.
Thread: https://gitlist.dev/t/57354

## Shaoxuan Yuan, 2022-02-02 07:28

Subject: [PATCH] builtin/diff.c: fix "git-diff" usage string typo
Message-ID: <20220202072844.35545-1-shaoxuan.yuan02@gmail.com>
URL: https://gitlist.dev/e/20220202072844.35545-1-shaoxuan.yuan02%40gmail.com

```
Remove mistaken right square brackets from "git-diff"
usage string. Make the usage string conform to "git-diff"
documentation (Documentation/git-diff.txt).

Signed-off-by: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
---
 builtin/diff.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/builtin/diff.c b/builtin/diff.c
index fa4683377e..bb7fafca61 100644
--- a/builtin/diff.c
+++ b/builtin/diff.c
@@ -28,9 +28,9 @@ static const char builtin_diff_usage[] =
 "git diff [<options>] [<commit>] [--] [<path>...]\n"
 "   or: git diff [<options>] --cached [--merge-base] [<commit>] [--] [<path>...]\n"
 "   or: git diff [<options>] [--merge-base] <commit> [<commit>...] <commit> [--] [<path>...]\n"
-"   or: git diff [<options>] <commit>...<commit>] [--] [<path>...]\n"
-"   or: git diff [<options>] <blob> <blob>]\n"
-"   or: git diff [<options>] --no-index [--] <path> <path>]\n"
+"   or: git diff [<options>] <commit>...<commit> [--] [<path>...]\n"
+"   or: git diff [<options>] <blob> <blob>\n"
+"   or: git diff [<options>] --no-index [--] <path> <path>\n"
 COMMON_DIFF_OPTIONS_HELP;
 
 static const char *blob_path(struct object_array_entry *entry)
-- 
2.35.0


```

## Christian Couder, 2022-02-02 17:44

Subject: Re: [PATCH] builtin/diff.c: fix "git-diff" usage string typo
Message-ID: <CAP8UFD21Cv50JaqnktywcTQ2XBx7-SqeXnBqQOZT=o_mDHLgmw@mail.gmail.com>
URL: https://gitlist.dev/e/CAP8UFD21Cv50JaqnktywcTQ2XBx7-SqeXnBqQOZT%3Do_mDHLgmw%40mail.gmail.com
In-Reply-To: <20220202072844.35545-1-shaoxuan.yuan02@gmail.com>

```
On Wed, Feb 2, 2022 at 8:29 AM Shaoxuan Yuan <shaoxuan.yuan02@gmail.com> wrote:
>
> Remove mistaken right square brackets from "git-diff"
> usage string. Make the usage string conform to "git-diff"
> documentation (Documentation/git-diff.txt).
>
> Signed-off-by: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>

This looks good to me!

Thanks,
Christian.

```