# [PATCH 0/2] docs: apply minor fixes to Documentation/config/pgp.txt 11 messages from 2022-01-25 to 2022-01-27. Participants: Greg Hurrell, Ævar Arnfjörð Bjarmason, Junio C Hamano. Thread: https://gitlist.dev/t/57306 ## Greg Hurrell, 2022-01-25 12:37 Subject: [PATCH 0/2] docs: apply minor fixes to Documentation/config/pgp.txt Message-ID: <20220125123716.66991-1-greg@hurrell.net> URL: https://gitlist.dev/e/20220125123716.66991-1-greg%40hurrell.net ``` Two little fixes to the docs, adding a missing apostrophe and fixing a mid-sentence tab to a space, respectively. Documentation/config/gpg.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ``` ## Greg Hurrell, 2022-01-25 12:37 Subject: [PATCH 1/2] docs: Fix bad whitespace in Documentation/config/pgp.txt Message-ID: <20220125123716.66991-2-greg@hurrell.net> URL: https://gitlist.dev/e/20220125123716.66991-2-greg%40hurrell.net In-Reply-To: <20220125123716.66991-1-greg@hurrell.net> ``` Signed-off-by: Greg Hurrell --- Documentation/config/gpg.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/config/gpg.txt b/Documentation/config/gpg.txt index 0cb189a077..abfabd6d62 100644 --- a/Documentation/config/gpg.txt +++ b/Documentation/config/gpg.txt @@ -37,7 +37,7 @@ gpg.minTrustLevel:: gpg.ssh.defaultKeyCommand:: This command that will be run when user.signingkey is not set and a ssh signature is requested. On successful exit a valid ssh public key is - expected in the first line of its output. To automatically use the first + expected in the first line of its output. To automatically use the first available key from your ssh-agent set this to "ssh-add -L". gpg.ssh.allowedSignersFile:: -- 2.35.0 ``` ## Greg Hurrell, 2022-01-25 12:37 Subject: [PATCH 2/2] docs: add missing apostrophe to Documentation/config/gpg.txt Message-ID: <20220125123716.66991-3-greg@hurrell.net> URL: https://gitlist.dev/e/20220125123716.66991-3-greg%40hurrell.net In-Reply-To: <20220125123716.66991-1-greg@hurrell.net> ``` Add an apostrophe to "signatures" to indicate the possessive relationship in "the signature's creation". Signed-off-by: Greg Hurrell --- Documentation/config/gpg.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/config/gpg.txt b/Documentation/config/gpg.txt index abfabd6d62..86892ada77 100644 --- a/Documentation/config/gpg.txt +++ b/Documentation/config/gpg.txt @@ -66,7 +66,7 @@ This way only committers with an already valid key can add or change keys in the + Since OpensSSH 8.8 this file allows specifying a key lifetime using valid-after & valid-before options. Git will mark signatures as valid if the signing key was -valid at the time of the signatures creation. This allows users to change a +valid at the time of the signature's creation. This allows users to change a signing key without invalidating all previously made signatures. + Using a SSH CA key with the cert-authority option -- 2.35.0 ``` ## Ævar Arnfjörð Bjarmason, 2022-01-25 17:09 Subject: Re: [PATCH 1/2] docs: Fix bad whitespace in Documentation/config/pgp.txt Message-ID: <220125.861r0vhh8r.gmgdl@evledraar.gmail.com> URL: https://gitlist.dev/e/220125.861r0vhh8r.gmgdl%40evledraar.gmail.com In-Reply-To: <20220125123716.66991-2-greg@hurrell.net> ``` On Tue, Jan 25 2022, Greg Hurrell wrote: nit @ subject: I'd suggest: Documentation/config/pgp.txt: replace stray character with Or something, i.e. the "docs" can just be replaced by the filename, so we don't need to put it at the end. As general style, we tend to not have the part of ": " start with a capital letter, i.e. "fix" not "Fix". > Signed-off-by: Greg Hurrell > --- > Documentation/config/gpg.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/config/gpg.txt b/Documentation/config/gpg.txt > index 0cb189a077..abfabd6d62 100644 > --- a/Documentation/config/gpg.txt > +++ b/Documentation/config/gpg.txt > @@ -37,7 +37,7 @@ gpg.minTrustLevel:: > gpg.ssh.defaultKeyCommand:: > This command that will be run when user.signingkey is not set and a ssh > signature is requested. On successful exit a valid ssh public key is > - expected in the first line of its output. To automatically use the first > + expected in the first line of its output. To automatically use the first Since I had to look it's a s/\t/ / of a tab between "the" and "first" in the pre-image> ``` ## Greg Hurrell, 2022-01-26 12:14 Subject: [PATCH v2 0/2] Apply minor fixes to Documentation/config/pgp.txt Message-ID: <20220126121426.53799-1-greg@hurrell.net> URL: https://gitlist.dev/e/20220126121426.53799-1-greg%40hurrell.net In-Reply-To: <220125.861r0vhh8r.gmgdl@evledraar.gmail.com> ``` Just applying changes to commit messages as suggested by Ævar Arnfjörð Bjarmason: > nit @ subject: I'd suggest: > > Documentation/config/pgp.txt: replace stray character with > > Or something, i.e. the "docs" can just be replaced by the filename, so > we don't need to put it at the end. > > As general style, we tend to not have the part of ": > " start with a capital letter, i.e. "fix" not "Fix". ``` ## Greg Hurrell, 2022-01-26 12:14 Subject: [PATCH v2 1/2] Documentation/config/pgp.txt: replace stray character with Message-ID: <20220126121426.53799-2-greg@hurrell.net> URL: https://gitlist.dev/e/20220126121426.53799-2-greg%40hurrell.net In-Reply-To: <20220126121426.53799-1-greg@hurrell.net> ``` Specifically, replace the tab between "the" and "first" with a space. Signed-off-by: Greg Hurrell --- Documentation/config/gpg.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/config/gpg.txt b/Documentation/config/gpg.txt index 0cb189a077..abfabd6d62 100644 --- a/Documentation/config/gpg.txt +++ b/Documentation/config/gpg.txt @@ -37,7 +37,7 @@ gpg.minTrustLevel:: gpg.ssh.defaultKeyCommand:: This command that will be run when user.signingkey is not set and a ssh signature is requested. On successful exit a valid ssh public key is - expected in the first line of its output. To automatically use the first + expected in the first line of its output. To automatically use the first available key from your ssh-agent set this to "ssh-add -L". gpg.ssh.allowedSignersFile:: -- 2.35.0 ``` ## Greg Hurrell, 2022-01-26 12:14 Subject: [PATCH 2/2] Documentation/config/pgp.txt: add missing apostrophe Message-ID: <20220126121426.53799-3-greg@hurrell.net> URL: https://gitlist.dev/e/20220126121426.53799-3-greg%40hurrell.net In-Reply-To: <20220126121426.53799-1-greg@hurrell.net> ``` Add an apostrophe to "signatures" to indicate the possessive relationship in "the signature's creation". Signed-off-by: Greg Hurrell --- Documentation/config/gpg.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/config/gpg.txt b/Documentation/config/gpg.txt index abfabd6d62..86892ada77 100644 --- a/Documentation/config/gpg.txt +++ b/Documentation/config/gpg.txt @@ -66,7 +66,7 @@ This way only committers with an already valid key can add or change keys in the + Since OpensSSH 8.8 this file allows specifying a key lifetime using valid-after & valid-before options. Git will mark signatures as valid if the signing key was -valid at the time of the signatures creation. This allows users to change a +valid at the time of the signature's creation. This allows users to change a signing key without invalidating all previously made signatures. + Using a SSH CA key with the cert-authority option -- 2.35.0 ``` ## Junio C Hamano, 2022-01-27 02:30 Subject: Re: [PATCH v2 1/2] Documentation/config/pgp.txt: replace stray character with Message-ID: URL: https://gitlist.dev/e/xmqq5yq56hbu.fsf%40gitster.g In-Reply-To: <20220126121426.53799-2-greg@hurrell.net> ``` Greg Hurrell writes: > Specifically, replace the tab between "the" and "first" with a space. Good eyes. Does it have ANY practical downside to leave it unfixed? In other words, how did you spot it (e.g. "asciidoctor passes tab as-is and screwed up an alignment of the text, which was how I noticed it")? Thanks. > > Signed-off-by: Greg Hurrell > --- > Documentation/config/gpg.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/config/gpg.txt b/Documentation/config/gpg.txt > index 0cb189a077..abfabd6d62 100644 > --- a/Documentation/config/gpg.txt > +++ b/Documentation/config/gpg.txt > @@ -37,7 +37,7 @@ gpg.minTrustLevel:: > gpg.ssh.defaultKeyCommand:: > This command that will be run when user.signingkey is not set and a ssh > signature is requested. On successful exit a valid ssh public key is > - expected in the first line of its output. To automatically use the first > + expected in the first line of its output. To automatically use the first > available key from your ssh-agent set this to "ssh-add -L". > > gpg.ssh.allowedSignersFile:: ``` ## Junio C Hamano, 2022-01-27 02:30 Subject: Re: [PATCH 2/2] Documentation/config/pgp.txt: add missing apostrophe Message-ID: URL: https://gitlist.dev/e/xmqq1r0t6hb3.fsf%40gitster.g In-Reply-To: <20220126121426.53799-3-greg@hurrell.net> ``` Greg Hurrell writes: > Add an apostrophe to "signatures" to indicate the possessive > relationship in "the signature's creation". > > Signed-off-by: Greg Hurrell > --- > Documentation/config/gpg.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks. Will queue. > diff --git a/Documentation/config/gpg.txt b/Documentation/config/gpg.txt > index abfabd6d62..86892ada77 100644 > --- a/Documentation/config/gpg.txt > +++ b/Documentation/config/gpg.txt > @@ -66,7 +66,7 @@ This way only committers with an already valid key can add or change keys in the > + > Since OpensSSH 8.8 this file allows specifying a key lifetime using valid-after & > valid-before options. Git will mark signatures as valid if the signing key was > -valid at the time of the signatures creation. This allows users to change a > +valid at the time of the signature's creation. This allows users to change a > signing key without invalidating all previously made signatures. > + > Using a SSH CA key with the cert-authority option ``` ## Greg Hurrell, 2022-01-27 08:20 Subject: Re: [PATCH v2 1/2] Documentation/config/pgp.txt: replace stray character with Message-ID: <4216fdca-cf73-4bf6-b911-90c6c7ba0e2d@beta.fastmail.com> URL: https://gitlist.dev/e/4216fdca-cf73-4bf6-b911-90c6c7ba0e2d%40beta.fastmail.com In-Reply-To: ``` On Thu, Jan 27, 2022, at 3:30 AM, Junio C Hamano wrote: > Greg Hurrell writes: > > > Specifically, replace the tab between "the" and "first" with a space. > > Good eyes. Does it have ANY practical downside to leave it unfixed? > > In other words, how did you spot it (e.g. "asciidoctor passes tab as-is > and screwed up an alignment of the text, which was how I noticed it")? The nearby fix (the apostrophe) in the other commit was what had me looking at this file in the first place. But my editor (Neovim) made the mid-line tab visually obvious, so I figured may as well clean it up along the way; on my screen it looked something like this: ▷┅┅┅signature is requested. On successful exit a valid ssh public key is ▷┅┅┅expected in the▷┅┅┅first line of its output. To automatically use the first ▷┅┅┅available key from your ssh-agent set this to "ssh-add -L". Vim's "listchars" setting is responsible for making tabs visible like that: :set listchars=extends:»,nbsp:⦸,precedes:«,tab:▷⋯,trail:• Greg ``` ## Junio C Hamano, 2022-01-27 17:50 Subject: Re: [PATCH v2 1/2] Documentation/config/pgp.txt: replace stray character with Message-ID: URL: https://gitlist.dev/e/xmqqee4t3w5x.fsf%40gitster.g In-Reply-To: <4216fdca-cf73-4bf6-b911-90c6c7ba0e2d@beta.fastmail.com> ``` "Greg Hurrell" writes: > On Thu, Jan 27, 2022, at 3:30 AM, Junio C Hamano wrote: >> Greg Hurrell writes: >> >> > Specifically, replace the tab between "the" and "first" with a space. >> >> Good eyes. Does it have ANY practical downside to leave it unfixed? >> >> In other words, how did you spot it (e.g. "asciidoctor passes tab as-is >> and screwed up an alignment of the text, which was how I noticed it")? > > The nearby fix (the apostrophe) in the other commit was what had me > looking at this file in the first place. But my editor (Neovim) > made the mid-line tab visually obvious, so I figured may as well clean Ah, yes, highlighting editors and pagers. I forgot about them. In any case, thanks for the fixes. Queued. ```