# Re: [PATCH v6 5/6] unpack-objects.c: add dry_run mode for get_data()

2 messages from 2021-12-21 to 2021-12-21. Participants: Han Xin, Junio C Hamano.
Thread: https://gitlist.dev/t/57127

## Han Xin, 2021-12-21 11:40

Subject: Re: [PATCH v6 5/6] unpack-objects.c: add dry_run mode for get_data()
Message-ID: <CAO0brD1f+w_J1jVzsBb0ewc7Ndwiz5pLC2QOG11r5-H0XetOAQ@mail.gmail.com>
URL: https://gitlist.dev/e/CAO0brD1f%2Bw_J1jVzsBb0ewc7Ndwiz5pLC2QOG11r5-H0XetOAQ%40mail.gmail.com

```
> Clever.  Looks good to me.
>
> For some reason I was expecting this patch to have some connection to
> one of the earlier ones (perhaps because get_data() was mentioned),
> but it is technically independent.

I think I should adjust the order of this patch to move it forward.

Thanks
-Han Xin

```

## Junio C Hamano, 2021-12-21 17:17

Subject: Re: [PATCH v6 5/6] unpack-objects.c: add dry_run mode for get_data()
Message-ID: <xmqqh7b1q3ll.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqqh7b1q3ll.fsf%40gitster.g
In-Reply-To: <CAO0brD1f+w_J1jVzsBb0ewc7Ndwiz5pLC2QOG11r5-H0XetOAQ@mail.gmail.com>

```
Han Xin <chiyutianyi@gmail.com> writes:

>> Clever.  Looks good to me.
>>
>> For some reason I was expecting this patch to have some connection to
>> one of the earlier ones (perhaps because get_data() was mentioned),
>> but it is technically independent.
>
> I think I should adjust the order of this patch to move it forward.

Or just eject it from the series and send it in as an independent
single patch?

```