# [PATCH] t4202: fix patternType setting in --invert-grep test 2 messages from 2021-12-17 to 2021-12-18. Participants: René Scharfe, Junio C Hamano. Thread: https://gitlist.dev/t/57110 ## René Scharfe, 2021-12-17 16:48 Subject: [PATCH] t4202: fix patternType setting in --invert-grep test Message-ID: <79dcebc0-e569-cc8a-4702-c572b062ed6d@web.de> URL: https://gitlist.dev/e/79dcebc0-e569-cc8a-4702-c572b062ed6d%40web.de ``` Actually use extended regexes as indicated in the comment. Signed-off-by: René Scharfe --- t/t4202-log.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t4202-log.sh b/t/t4202-log.sh index 7884e3d46b..f51b57b4a2 100755 --- a/t/t4202-log.sh +++ b/t/t4202-log.sh @@ -250,7 +250,7 @@ test_expect_success 'log --invert-grep --grep' ' test_cmp expect actual && # POSIX extended - git -c grep.patternType=basic log --pretty="tformat:%s" --invert-grep --grep=t[h] --grep=S[e]c >actual && + git -c grep.patternType=extended log --pretty="tformat:%s" --invert-grep --grep=t[h] --grep=S[e]c >actual && test_cmp expect actual && # PCRE -- 2.34.0 ``` ## Junio C Hamano, 2021-12-18 00:14 Subject: Re: [PATCH] t4202: fix patternType setting in --invert-grep test Message-ID: URL: https://gitlist.dev/e/xmqq5yrm22gv.fsf%40gitster.g In-Reply-To: <79dcebc0-e569-cc8a-4702-c572b062ed6d@web.de> ``` René Scharfe writes: > Actually use extended regexes as indicated in the comment. > > Signed-off-by: René Scharfe > --- > t/t4202-log.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t4202-log.sh b/t/t4202-log.sh > index 7884e3d46b..f51b57b4a2 100755 > --- a/t/t4202-log.sh > +++ b/t/t4202-log.sh > @@ -250,7 +250,7 @@ test_expect_success 'log --invert-grep --grep' ' > test_cmp expect actual && > > # POSIX extended > - git -c grep.patternType=basic log --pretty="tformat:%s" --invert-grep --grep=t[h] --grep=S[e]c >actual && > + git -c grep.patternType=extended log --pretty="tformat:%s" --invert-grep --grep=t[h] --grep=S[e]c >actual && > test_cmp expect actual && Good eyes. Thanks. ```