# [PATCH] git-svn: Fix fetch --no-ignore-externals with GIT_SVN_NO_LIB=1 2 messages from 2006-09-26 to 2006-09-26. Participants: Sergey Vlasov, Eric Wong. Thread: https://gitlist.dev/t/5699 ## Sergey Vlasov, 2006-09-26 09:42 Subject: [PATCH] git-svn: Fix fetch --no-ignore-externals with GIT_SVN_NO_LIB=1 Message-ID: <1159263775639-git-send-email-vsu@altlinux.ru> URL: https://gitlist.dev/e/1159263775639-git-send-email-vsu%40altlinux.ru ``` When using Subversion 1.3.1 without Perl bindings (GIT_SVN_NO_LIB=1), "git-svn fetch --no-ignore-externals" fails with errors like: Tree (.../.git/svn/git-svn/tree) is not clean: X directory_with_external In this case the 'X' lines in the "svn status" output are not a sign of unclean tree, and therefore should be ignored. Signed-off-by: Sergey Vlasov --- git-svn.perl | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/git-svn.perl b/git-svn.perl index 0290850..2f5cf90 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -1246,6 +1246,7 @@ sub assert_svn_wc_clean { } my @status = grep(!/^Performing status on external/,(`svn status`)); @status = grep(!/^\s*$/,@status); + @status = grep(!/^X/,@status) if $_no_ignore_ext; if (scalar @status) { print STDERR "Tree ($SVN_WC) is not clean:\n"; print STDERR $_ foreach @status; -- 1.4.2.1.ga8608c ``` ## Eric Wong, 2006-09-26 18:14 Subject: Re: [PATCH] git-svn: Fix fetch --no-ignore-externals with GIT_SVN_NO_LIB=1 Message-ID: <20060926181401.GA1479@hand.yhbt.net> URL: https://gitlist.dev/e/20060926181401.GA1479%40hand.yhbt.net In-Reply-To: <1159263775639-git-send-email-vsu@altlinux.ru> ``` Sergey Vlasov wrote: > When using Subversion 1.3.1 without Perl bindings (GIT_SVN_NO_LIB=1), > "git-svn fetch --no-ignore-externals" fails with errors like: > > Tree (.../.git/svn/git-svn/tree) is not clean: > X directory_with_external > > In this case the 'X' lines in the "svn status" output are not a sign > of unclean tree, and therefore should be ignored. > > Signed-off-by: Sergey Vlasov Acked-by: Eric Wong -- Eric Wong ```