# [ANNOUNCE] Git v2.34.1

6 messages from 2021-11-24 to 2021-11-24. Participants: Junio C Hamano, rsbecker@nexbridge.com.
Thread: https://gitlist.dev/t/56971

## Junio C Hamano, 2021-11-24 20:28

Subject: [ANNOUNCE] Git v2.34.1
Message-ID: <xmqq7dcx1ent.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqq7dcx1ent.fsf%40gitster.g

```
The latest maintenance release Git v2.34.1 is now available at
the usual places.

The tarballs are found at:

    https://www.kernel.org/pub/software/scm/git/

The following public repositories all have a copy of the 'v2.34.1'
tag and the 'maint' branch that the tag points at:

  url = https://git.kernel.org/pub/scm/git/git
  url = https://kernel.googlesource.com/pub/scm/git/git
  url = git://repo.or.cz/alt-git.git
  url = https://github.com/gitster/git

----------------------------------------------------------------

Git v2.34.1 Release Notes
=========================

This release is primarily to fix a handful of regressions in Git 2.34.

Fixes since v2.34
-----------------

 * "git grep" looking in a blob that has non-UTF8 payload was
   completely broken when linked with certain versions of PCREv2
   library in the latest release.

 * "git pull" with any strategy when the other side is behind us
   should succeed as it is a no-op, but doesn't.

 * An earlier change in 2.34.0 caused JGit application (that abused
   GIT_EDITOR mechanism when invoking "git config") to get stuck with
   a SIGTTOU signal; it has been reverted.

 * An earlier change that broke .gitignore matching has been reverted.

 * SubmittingPatches document gained a syntactically incorrect mark-up,
   which has been corrected.

----------------------------------------------------------------

Changes since v2.34.0 are as follows:

Derrick Stolee (1):
      dir: revert "dir: select directories correctly"

Erwin Villejo (1):
      pull: should be noop when already-up-to-date

Junio C Hamano (3):
      Revert "grep/pcre2: fix an edge case concerning ascii patterns and UTF-8 data"
      Revert "editor: save and reset terminal after calling EDITOR"
      Git 2.34.1

Philippe Blain (1):
      SubmittingPatches: fix Asciidoc syntax in "GitHub CI" section


```

## rsbecker@nexbridge.com, 2021-11-24 20:38

Subject: RE: [ANNOUNCE] Git v2.34.1
Message-ID: <000201d7e173$3eb3d320$bc1b7960$@nexbridge.com>
URL: https://gitlist.dev/e/000201d7e173%243eb3d320%24bc1b7960%24%40nexbridge.com
In-Reply-To: <xmqq7dcx1ent.fsf@gitster.g>

```
On November 24, 2021 3:29 PM, Junio C Hamano wrote:
> Subject: [ANNOUNCE] Git v2.34.1
> 
> The latest maintenance release Git v2.34.1 is now available at the usual
> places.
> 
> The tarballs are found at:
> 
>     https://www.kernel.org/pub/software/scm/git/
>
> The following public repositories all have a copy of the 'v2.34.1'
> tag and the 'maint' branch that the tag points at:
> 
>   url = https://git.kernel.org/pub/scm/git/git
>   url = https://kernel.googlesource.com/pub/scm/git/git
>   url = git://repo.or.cz/alt-git.git
>   url = https://github.com/gitster/git

In an unusual situation, make reports:

GIT_VERSION = 2.34.GIT

Instead of the expected

GIT_VERSION = 2.34.1

which we see usually.

Am I missing a step that was added since 2.34.0?

-Randall


```

## rsbecker@nexbridge.com, 2021-11-24 20:44

Subject: RE: [ANNOUNCE] Git v2.34.1
Message-ID: <000301d7e174$1b568570$52039050$@nexbridge.com>
URL: https://gitlist.dev/e/000301d7e174%241b568570%2452039050%24%40nexbridge.com
In-Reply-To: <000201d7e173$3eb3d320$bc1b7960$@nexbridge.com>

```
On November 24, 2021 3:38 PM, I wrote:
> On November 24, 2021 3:29 PM, Junio C Hamano wrote:
> > Subject: [ANNOUNCE] Git v2.34.1
> >
> > The latest maintenance release Git v2.34.1 is now available at the
> > usual places.
> >
> > The tarballs are found at:
> >
> >     https://www.kernel.org/pub/software/scm/git/
> >
> > The following public repositories all have a copy of the 'v2.34.1'
> > tag and the 'maint' branch that the tag points at:
> >
> >   url = https://git.kernel.org/pub/scm/git/git
> >   url = https://kernel.googlesource.com/pub/scm/git/git
> >   url = git://repo.or.cz/alt-git.git
> >   url = https://github.com/gitster/git
> 
> In an unusual situation, make reports:
> 
> GIT_VERSION = 2.34.GIT
> 
> Instead of the expected
> 
> GIT_VERSION = 2.34.1
> 
> which we see usually.
> 
> Am I missing a step that was added since 2.34.0?

Oops. I have to build off 'maint' not master. Got it.
-R.


```

## Junio C Hamano, 2021-11-24 20:47

Subject: Re: [ANNOUNCE] Git v2.34.1
Message-ID: <xmqq35nl1dsh.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqq35nl1dsh.fsf%40gitster.g
In-Reply-To: <000301d7e174$1b568570$52039050$@nexbridge.com>

```
<rsbecker@nexbridge.com> writes:

>> In an unusual situation, make reports:
>> 
>> GIT_VERSION = 2.34.GIT
>> 
>> Instead of the expected
>> 
>> GIT_VERSION = 2.34.1
>> 
>> which we see usually.
>> 
>> Am I missing a step that was added since 2.34.0?
>
> Oops. I have to build off 'maint' not master. Got it.
> -R.

You made me cut my lunch break short to double check, but all is
well if the release materials are good after all ;-)


```

## rsbecker@nexbridge.com, 2021-11-24 21:12

Subject: RE: [ANNOUNCE] Git v2.34.1
Message-ID: <000c01d7e177$f43327b0$dc997710$@nexbridge.com>
URL: https://gitlist.dev/e/000c01d7e177%24f43327b0%24dc997710%24%40nexbridge.com
In-Reply-To: <xmqq35nl1dsh.fsf@gitster.g>

```
On November 24, 2021 3:48 PM, Junio C Hamano:
> <rsbecker@nexbridge.com> writes:
> 
> >> In an unusual situation, make reports:
> >>
> >> GIT_VERSION = 2.34.GIT
> >>
> >> Instead of the expected
> >>
> >> GIT_VERSION = 2.34.1
> >>
> >> which we see usually.
> >>
> >> Am I missing a step that was added since 2.34.0?
> >
> > Oops. I have to build off 'maint' not master. Got it.
> > -R.
> 
> You made me cut my lunch break short to double check, but all is well if the
> release materials are good after all ;-)

Hopefully when travel is permitted and I can next get to your area, I can repair this with beer 😉
Cheers,
-Randall


```

## Junio C Hamano, 2021-11-24 21:21

Subject: Re: [ANNOUNCE] Git v2.34.1
Message-ID: <xmqqilwhz1ua.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqqilwhz1ua.fsf%40gitster.g
In-Reply-To: <000c01d7e177$f43327b0$dc997710$@nexbridge.com>

```
<rsbecker@nexbridge.com> writes:

> On November 24, 2021 3:48 PM, Junio C Hamano:
>> <rsbecker@nexbridge.com> writes:
>> 
>> >> In an unusual situation, make reports:
>> >>
>> >> GIT_VERSION = 2.34.GIT
>> >>
>> >> Instead of the expected
>> >>
>> >> GIT_VERSION = 2.34.1
>> >>
>> >> which we see usually.
>> >>
>> >> Am I missing a step that was added since 2.34.0?
>> >
>> > Oops. I have to build off 'maint' not master. Got it.
>> > -R.
>> 
>> You made me cut my lunch break short to double check, but all is well if the
>> release materials are good after all ;-)
>
> Hopefully when travel is permitted and I can next get to your area, I can repair this with beer 😉
> Cheers,
> -Randall

Cheers.  There is nothing to repair.  I don't drink, but thanks for
the thought.

Have fun.

```
