# [PATCH] t5310: drop lib-bundle.sh include 3 messages from 2021-10-28 to 2021-10-29. Participants: Jeff King, Junio C Hamano, Ævar Arnfjörð Bjarmason. Thread: https://gitlist.dev/t/56803 ## Jeff King, 2021-10-28 19:20 Subject: [PATCH] t5310: drop lib-bundle.sh include Message-ID: URL: https://gitlist.dev/e/YXr3%2ByqtXYGgaxnX%40coredump.intra.peff.net ``` Commit ddfe900612 (test-lib-functions: move function to lib-bitmap.sh, 2021-02-09) meant to include lib-bitmap.sh in t5310, but also includes lib-bundle.sh. Yet we don't use any of its functions, nor have anything to do with bundles. This is probably just a typo/copy-paste error, as lib-bundle.sh was added (correctly) to other scripts in the same series. Signed-off-by: Jeff King --- Not really hurting anything, just confusing. t/t5310-pack-bitmaps.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh index 673baa5c3c..dcf03d324a 100755 --- a/t/t5310-pack-bitmaps.sh +++ b/t/t5310-pack-bitmaps.sh @@ -5,7 +5,6 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME . ./test-lib.sh -. "$TEST_DIRECTORY"/lib-bundle.sh . "$TEST_DIRECTORY"/lib-bitmap.sh # t5310 deals only with single-pack bitmaps, so don't write MIDX bitmaps in -- 2.33.1.1409.g5a89a36363 ``` ## Junio C Hamano, 2021-10-29 07:04 Subject: Re: [PATCH] t5310: drop lib-bundle.sh include Message-ID: URL: https://gitlist.dev/e/xmqq35okmhv5.fsf%40gitster.g In-Reply-To: ``` Jeff King writes: > Commit ddfe900612 (test-lib-functions: move function to lib-bitmap.sh, > 2021-02-09) meant to include lib-bitmap.sh in t5310, but also includes > lib-bundle.sh. Yet we don't use any of its functions, nor have anything > to do with bundles. This is probably just a typo/copy-paste error, as > lib-bundle.sh was added (correctly) to other scripts in the same series. > > Signed-off-by: Jeff King > --- > Not really hurting anything, just confusing. Makes sense to me. Will queue; thanks. > > t/t5310-pack-bitmaps.sh | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh > index 673baa5c3c..dcf03d324a 100755 > --- a/t/t5310-pack-bitmaps.sh > +++ b/t/t5310-pack-bitmaps.sh > @@ -5,7 +5,6 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master > export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME > > . ./test-lib.sh > -. "$TEST_DIRECTORY"/lib-bundle.sh > . "$TEST_DIRECTORY"/lib-bitmap.sh > > # t5310 deals only with single-pack bitmaps, so don't write MIDX bitmaps in ``` ## Ævar Arnfjörð Bjarmason, 2021-10-29 10:16 Subject: Re: [PATCH] t5310: drop lib-bundle.sh include Message-ID: <211029.86fsskw2yh.gmgdl@evledraar.gmail.com> URL: https://gitlist.dev/e/211029.86fsskw2yh.gmgdl%40evledraar.gmail.com In-Reply-To: ``` On Thu, Oct 28 2021, Jeff King wrote: > Commit ddfe900612 (test-lib-functions: move function to lib-bitmap.sh, > 2021-02-09) meant to include lib-bitmap.sh in t5310, but also includes > lib-bundle.sh. Yet we don't use any of its functions, nor have anything > to do with bundles. This is probably just a typo/copy-paste error, as > lib-bundle.sh was added (correctly) to other scripts in the same series. > > Signed-off-by: Jeff King > --- > Not really hurting anything, just confusing. > > t/t5310-pack-bitmaps.sh | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh > index 673baa5c3c..dcf03d324a 100755 > --- a/t/t5310-pack-bitmaps.sh > +++ b/t/t5310-pack-bitmaps.sh > @@ -5,7 +5,6 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master > export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME > > . ./test-lib.sh > -. "$TEST_DIRECTORY"/lib-bundle.sh > . "$TEST_DIRECTORY"/lib-bitmap.sh > > # t5310 deals only with single-pack bitmaps, so don't write MIDX bitmaps in Thanks for cleaning that up, yes that wasn't intentional, but just some copy/paste programming or something that managed to escape me & the list. Thanks! ```