# New built-in fsmonitor: messages accidentally on stdout? 4 messages from 2021-09-24 to 2021-10-05. Participants: Tao Klerks, Jeff Hostetler, Johannes Schindelin. Thread: https://gitlist.dev/t/56584 ## Tao Klerks, 2021-09-24 18:02 Subject: New built-in fsmonitor: messages accidentally on stdout? Message-ID: URL: https://gitlist.dev/e/CAPMMpoj-oiD1yDHx6WS_1uiPOXMLj7FcfBPZm-q4vO30kpE_ow%40mail.gmail.com ``` Hi folks, I've been testing the new "core.usebuiltinfsmonitor=true" capability in Git for Windows 2.33.0.windows.2, and came across something today that threw off my scripting: In general, git "informational" messages are always output on stderr; this caught me out initially, but is a godsend for scripting. However, with this new functionality, the "starting fsmonitor-daemon in 'C:/whatever" message is being output on stdout! This interferes with scripting around things like "git status --porcelain". I understand this fsmonitor stuff is still somewhat in-flux (patched into the windows port but not yet "regular" git releases?), and this issue may already have been reported and addressed in the latest set of patches - my apologies if that is the case! Best regards, Tao ``` ## Tao Klerks, 2021-09-27 09:32 Subject: Re: New built-in fsmonitor: messages accidentally on stdout? Message-ID: URL: https://gitlist.dev/e/CAPMMpoic0Dt%3D5Z7GB7BG7CqwxAs49SPPDkdasUPvasvsPhr-tg%40mail.gmail.com In-Reply-To: ``` Hi folks, I did track down where that message was being issued onto stdout in git-for-windows (https://github.com/git-for-windows/git/blob/main/builtin/fsmonitor--daemon.c), and I see that in the the latest version of the patch series it was already switched to stderr (https://github.com/jeffhostetler/git/blob/f08a63e197a0efe4d8f0452893238b0d3156e669/builtin/fsmonitor--daemon.c). The only remaining thing I can ask for, I guess, is that the next Git for Windows release ideally include this change/fix, even though the built-in fsmonitor is not in "regular git" at all yet? Thanks, Tao On Fri, Sep 24, 2021 at 8:02 PM Tao Klerks wrote: > > Hi folks, > > I've been testing the new "core.usebuiltinfsmonitor=true" capability > in Git for Windows 2.33.0.windows.2, and came across something today > that threw off my scripting: > > In general, git "informational" messages are always output on stderr; > this caught me out initially, but is a godsend for scripting. > > However, with this new functionality, the "starting fsmonitor-daemon > in 'C:/whatever" message is being output on stdout! > > This interferes with scripting around things like "git status --porcelain". > > I understand this fsmonitor stuff is still somewhat in-flux (patched > into the windows port but not yet "regular" git releases?), and this > issue may already have been reported and addressed in the latest set > of patches - my apologies if that is the case! > > Best regards, > Tao ``` ## Jeff Hostetler, 2021-09-27 13:52 Subject: Re: New built-in fsmonitor: messages accidentally on stdout? Message-ID: URL: https://gitlist.dev/e/c0ff1914-8bf2-fb10-ea74-d35cf86508a1%40jeffhostetler.com In-Reply-To: ``` On 9/27/21 5:32 AM, Tao Klerks wrote: > Hi folks, > > I did track down where that message was being issued onto stdout in > git-for-windows > (https://github.com/git-for-windows/git/blob/main/builtin/fsmonitor--daemon.c), > and I see that in the the latest version of the patch series it was > already switched to stderr > (https://github.com/jeffhostetler/git/blob/f08a63e197a0efe4d8f0452893238b0d3156e669/builtin/fsmonitor--daemon.c). > > The only remaining thing I can ask for, I guess, is that the next Git > for Windows release ideally include this change/fix, even though the > built-in fsmonitor is not in "regular git" at all yet? Yes, I've fixed that in my branch to print to stderr (and also put it behind a feature flag). If my current series does not make it into core Git in time for the next release, we will update the experimental version in the next git-for-windows release. Thanks, Jeff ``` ## Johannes Schindelin, 2021-10-05 08:43 Subject: Re: New built-in fsmonitor: messages accidentally on stdout? Message-ID: URL: https://gitlist.dev/e/nycvar.QRO.7.76.6.2110051043110.395%40tvgsbejvaqbjf.bet In-Reply-To: ``` Hi Tao, On Mon, 27 Sep 2021, Tao Klerks wrote: > I did track down where that message was being issued onto stdout in > git-for-windows > (https://github.com/git-for-windows/git/blob/main/builtin/fsmonitor--daemon.c), > and I see that in the the latest version of the patch series it was > already switched to stderr > (https://github.com/jeffhostetler/git/blob/f08a63e197a0efe4d8f0452893238b0d3156e669/builtin/fsmonitor--daemon.c). > > The only remaining thing I can ask for, I guess, is that the next Git > for Windows release ideally include this change/fix, even though the > built-in fsmonitor is not in "regular git" at all yet? The latest snapshot at https://wingit.blob.core.windows.net/files/index.html should include the latest iteration of the FSMonitor feature. Ciao, Johannes > On Fri, Sep 24, 2021 at 8:02 PM Tao Klerks wrote: > > > > Hi folks, > > > > I've been testing the new "core.usebuiltinfsmonitor=true" capability > > in Git for Windows 2.33.0.windows.2, and came across something today > > that threw off my scripting: > > > > In general, git "informational" messages are always output on stderr; > > this caught me out initially, but is a godsend for scripting. > > > > However, with this new functionality, the "starting fsmonitor-daemon > > in 'C:/whatever" message is being output on stdout! > > > > This interferes with scripting around things like "git status --porcelain". > > > > I understand this fsmonitor stuff is still somewhat in-flux (patched > > into the windows port but not yet "regular" git releases?), and this > > issue may already have been reported and addressed in the latest set > > of patches - my apologies if that is the case! > > > > Best regards, > > Tao > ```