threads / rfc / 56507

RFC patchgitweb: Handle non-ASCII email addresses

Subject: [PATCH RFC] gitweb: Handle non-ASCII email addresses

## tl;dr

2 messages between Sep 15, 2021 and Sep 22, 2021. Diffs are folded; open one to read it.

replies: 1people: 1as markdown or json

Jan-Benedict Glaw· Sep 15, 2021, 19:26 UTC · lore

Hi!

I accidentally had a bad user.email setting ("jbglaw@ług-owl.de" instead of "jbglaw@lug-owl.de") and this leads to incomplete HTML being generated by gitweb, along with an error message:

index.cgi: Wide character in subroutine entry at /usr/share/gitweb/index.cgi line 2208.

This patch may fix it, but I'm NOT a Perl guy:

Show changes to gitweb/gitweb.perl +1 −1

--- a/gitweb/gitweb.perl	2021-09-15 20:23:13.788195846 +0200
+++ b/gitweb/gitweb.perl	2021-09-15 20:24:19.911806868 +0200
@@ -2193,7 +2193,7 @@
 	my $size = shift;
 	$avatar_cache{$email} ||=
 		"//www.gravatar.com/avatar/" .
-			md5_hex($email) . "?s=";
+			md5_hex(utf8::is_utf8($email)? Encode::encode_utf8($email): $email) . "?s=";
 	return $avatar_cache{$email} . $size;
 }


Comments?

Thanks,
  Jan-Benedict

Jan-Benedict Glaw· Sep 22, 2021, 17:42 UTC · re: Jan-Benedict Glaw · lore

*ping* [PATCH RFC] gitweb: Handle non-ASCII email addresses

Hi!

On Wed, 2021-09-15 21:26:47 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:

Show 21 quoted lines

> I accidentally had a bad user.email setting ("jbglaw@ług-owl.de"
> instead of "jbglaw@lug-owl.de") and this leads to incomplete HTML
> being generated by gitweb, along with an error message:
> 
> index.cgi: Wide character in subroutine entry at /usr/share/gitweb/index.cgi line 2208.
> 
> This patch may fix it, but I'm NOT a Perl guy:
> 
> --- a/gitweb/gitweb.perl	2021-09-15 20:23:13.788195846 +0200
> +++ b/gitweb/gitweb.perl	2021-09-15 20:24:19.911806868 +0200
> @@ -2193,7 +2193,7 @@
>  	my $size = shift;
>  	$avatar_cache{$email} ||=
>  		"//www.gravatar.com/avatar/" .
> -			md5_hex($email) . "?s=";
> +			md5_hex(utf8::is_utf8($email)? Encode::encode_utf8($email): $email) . "?s=";
>  	return $avatar_cache{$email} . $size;
>  }
> 
> 
> Comments?

I'd like to get some comment on this, maybe for anybody to merge it?

Thanks,
  Jan-Benedict