# [PATCH] setup: use xopen and xdup in sanitize_stdfds

1 messages from 2021-09-09 to 2021-09-09. Participants: René Scharfe.
Thread: https://gitlist.dev/t/56476

## René Scharfe, 2021-09-09 21:45

Subject: [PATCH] setup: use xopen and xdup in sanitize_stdfds
Message-ID: <2431d9cf-a2ed-ba4e-f7e5-a8427d9f9860@web.de>
URL: https://gitlist.dev/e/2431d9cf-a2ed-ba4e-f7e5-a8427d9f9860%40web.de

```
Replace the catch-all error message with specific ones for opening and
duplicating by calling the wrappers xopen and xdup.  The code becomes
easier to follow when error handling is reduced to two letters.

Remove the unnecessary mode parameter while at it -- we expect /dev/null
to already exist.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 setup.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/setup.c b/setup.c
index eb9367ca5c..347d7181ae 100644
--- a/setup.c
+++ b/setup.c
@@ -1423,11 +1423,9 @@ const char *resolve_gitdir_gently(const char *suspect, int *return_error_code)
 /* if any standard file descriptor is missing open it to /dev/null */
 void sanitize_stdfds(void)
 {
-	int fd = open("/dev/null", O_RDWR, 0);
-	while (fd != -1 && fd < 2)
-		fd = dup(fd);
-	if (fd == -1)
-		die_errno(_("open /dev/null or dup failed"));
+	int fd = xopen("/dev/null", O_RDWR);
+	while (fd < 2)
+		fd = xdup(fd);
 	if (fd > 2)
 		close(fd);
 }
--
2.33.0

```