# [PATCH] fixup! fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS 2 messages from 2021-08-19 to 2021-08-19. Participants: Carlo Marcelo Arenas Belón, Jeff Hostetler. Thread: https://gitlist.dev/t/56327 ## Carlo Marcelo Arenas Belón, 2021-08-19 18:36 Subject: [PATCH] fixup! fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS Message-ID: <20210819183652.7750-1-carenas@gmail.com> URL: https://gitlist.dev/e/20210819183652.7750-1-carenas%40gmail.com ``` clang defines __GNUC__ for compatibility with gcc (indeed it misrepresents itself as gcc 4.2.1), so instead use the __clang__ specific macro to distinguish between them. tested with Apple clang 12.0.5, clang 14 and gcc 11.2.0 Signed-off-by: Carlo Marcelo Arenas Belón --- compat/fsmonitor/fsmonitor-fs-listen-macos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/fsmonitor/fsmonitor-fs-listen-macos.c b/compat/fsmonitor/fsmonitor-fs-listen-macos.c index 02f89de216..c55ec35b5d 100644 --- a/compat/fsmonitor/fsmonitor-fs-listen-macos.c +++ b/compat/fsmonitor/fsmonitor-fs-listen-macos.c @@ -1,4 +1,4 @@ -#if defined(__GNUC__) +#ifndef __clang__ /* * It is possible to #include CoreFoundation/CoreFoundation.h when compiling * with clang, but not with GCC as of time of writing. -- 2.33.0.481.g26d3bed244 ``` ## Jeff Hostetler, 2021-08-19 20:48 Subject: Re: [PATCH] fixup! fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS Message-ID: URL: https://gitlist.dev/e/d2a962d3-f874-87e2-33dc-e0625ded5549%40jeffhostetler.com In-Reply-To: <20210819183652.7750-1-carenas@gmail.com> ``` On 8/19/21 2:36 PM, Carlo Marcelo Arenas Belón wrote: > clang defines __GNUC__ for compatibility with gcc (indeed it misrepresents > itself as gcc 4.2.1), so instead use the __clang__ specific macro to > distinguish between them. > > tested with Apple clang 12.0.5, clang 14 and gcc 11.2.0 > > Signed-off-by: Carlo Marcelo Arenas Belón > --- > compat/fsmonitor/fsmonitor-fs-listen-macos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/compat/fsmonitor/fsmonitor-fs-listen-macos.c b/compat/fsmonitor/fsmonitor-fs-listen-macos.c > index 02f89de216..c55ec35b5d 100644 > --- a/compat/fsmonitor/fsmonitor-fs-listen-macos.c > +++ b/compat/fsmonitor/fsmonitor-fs-listen-macos.c > @@ -1,4 +1,4 @@ > -#if defined(__GNUC__) > +#ifndef __clang__ > /* > * It is possible to #include CoreFoundation/CoreFoundation.h when compiling > * with clang, but not with GCC as of time of writing. > thanks! Jeff ```