# [PATCH] gitweb: Fix @git_base_url_list usage 5 messages from 2006-09-20 to 2006-09-22. Participants: Petr Baudis, Junio C Hamano. Thread: https://gitlist.dev/t/5613 ## Petr Baudis, 2006-09-20 00:09 Subject: [PATCH] gitweb: Fix @git_base_url_list usage Message-ID: <20060920000946.GC13132@pasky.or.cz> URL: https://gitlist.dev/e/20060920000946.GC13132%40pasky.or.cz ``` As it is now, that array was never used because the customurl accessor was broken and ''unless @url_list'' never happenned. Signed-off-by: Petr Baudis --- gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 2d0d56f..1b029ac 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -731,7 +731,7 @@ sub git_get_project_description { sub git_get_project_url_list { my $path = shift; - open my $fd, "$projectroot/$path/cloneurl" or return undef; + open my $fd, "$projectroot/$path/cloneurl" or return wantarray ? () : undef; my @git_project_url_list = map { chomp; $_ } <$fd>; close $fd; ``` ## Junio C Hamano, 2006-09-20 00:28 Subject: Re: [PATCH] gitweb: Fix @git_base_url_list usage Message-ID: <7v64fjnzyr.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7v64fjnzyr.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20060920000946.GC13132@pasky.or.cz> ``` Petr Baudis writes: > As it is now, that array was never used because the customurl accessor was > broken and ''unless @url_list'' never happenned. > > Signed-off-by: Petr Baudis > --- >... > sub git_get_project_url_list { > my $path = shift; > > - open my $fd, "$projectroot/$path/cloneurl" or return undef; > + open my $fd, "$projectroot/$path/cloneurl" or return wantarray ? () : undef; > my @git_project_url_list = map { chomp; $_ } <$fd>; > close $fd; Why on earth do you want to use wantarray for something like this? It's not like you are implementinging any fancy DWIM magic. Isn't open my $fd, "foobar" or return; much easier to read? #!/usr/bin/perl sub return_undef { open my $fd, "no-such-file" or return wantarray ? () : undef; } sub return_broken { open my $fd, "no-such-file" or return undef; } sub return_empty { open my $fd, "no-such-file" or return; } my $returned_undef_1 = return_undef(); my ($returned_undef_2) = return_undef(); my @returned_undef = return_undef(); my $returned_broken_1 = return_broken(); my ($returned_broken_2) = return_broken(); my @returned_broken = return_broken(); my $returned_empty_1 = return_empty(); my ($returned_empty_2) = return_empty(); my @returned_empty = return_empty(); printf "U %d B %d E %d\n", scalar(@returned_undef), scalar(@returned_broken), scalar(@returned_empty); for ($returned_undef_1, $returned_undef_2, $returned_broken_1, $returned_broken_2, $returned_empty_1, $returned_empty_2) { print "What I said was bogus.\n" if (defined $_); } ``` ## Junio C Hamano, 2006-09-20 00:43 Subject: Re: [PATCH] gitweb: Fix @git_base_url_list usage Message-ID: <7vodtbmkq2.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vodtbmkq2.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <7v64fjnzyr.fsf@assigned-by-dhcp.cox.net> ``` Junio C Hamano writes: > Why on earth do you want to use wantarray for something like > this? > > It's not like you are implementinging any fancy DWIM magic. Side note. I really hate it when people abuse wantarray. I can think of only two valid reasons (well, perhaps three but the last one is a logical consequence of the first two) to use wantarray. They are: (1) The information you are giving back the caller is list of things in nature, but there is a natural representation for that list as a single scalar, and that representation is not the last element of the list. You would want to help the caller by DWIMmery. Perl's built-in localtime() is an excellent example for wanting to do something like this. It returns broken-down "struct tm" in list context, but returns string ctime(3) in scalar context. (2) You want to avoid complex computations when the caller does not need full return values from you. A good example is found in perlfunc.pod: return unless defined wantarray; # don't bother doing more my @a = complex_calculation(); return wantarray ? @a : "@a"; (3) You are emulating Perl's built-in function that DWIMs for one of the above reasons, usually (1). ``` ## Petr Baudis, 2006-09-20 00:49 Subject: Re: [PATCH] gitweb: Fix @git_base_url_list usage Message-ID: <20060920004935.GJ8259@pasky.or.cz> URL: https://gitlist.dev/e/20060920004935.GJ8259%40pasky.or.cz In-Reply-To: <7v64fjnzyr.fsf@assigned-by-dhcp.cox.net> ``` Dear diary, on Wed, Sep 20, 2006 at 02:28:28AM CEST, I got a letter where Junio C Hamano said that... > Petr Baudis writes: > > > As it is now, that array was never used because the customurl accessor was > > broken and ''unless @url_list'' never happenned. > > > > Signed-off-by: Petr Baudis > > --- > >... > > sub git_get_project_url_list { > > my $path = shift; > > > > - open my $fd, "$projectroot/$path/cloneurl" or return undef; > > + open my $fd, "$projectroot/$path/cloneurl" or return wantarray ? () : undef; > > my @git_project_url_list = map { chomp; $_ } <$fd>; > > close $fd; > > Why on earth do you want to use wantarray for something like > this? > > It's not like you are implementinging any fancy DWIM magic. > > Isn't > > open my $fd, "foobar" or return; > > much easier to read? Sure, that's what I meant, I'm only already a bit tired so I just mimicked the other return in that sub, sorry. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ Snow falling on Perl. White noise covering line noise. Hides all the bugs too. -- J. Putnam ``` ## Petr Baudis, 2006-09-22 23:15 Subject: [PATCH] gitweb: Fix @git_base_url_list usage Message-ID: <20060922231518.32050.73077.stgit@rover> URL: https://gitlist.dev/e/20060922231518.32050.73077.stgit%40rover In-Reply-To: <20060920004935.GJ8259@pasky.or.cz> ``` As it is now, that array was never used because the customurl accessor was broken and ''unless @url_list'' never happenned. --- gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index f7e7d10..a357604 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -752,7 +752,7 @@ sub git_get_project_description { sub git_get_project_url_list { my $path = shift; - open my $fd, "$projectroot/$path/cloneurl" or return undef; + open my $fd, "$projectroot/$path/cloneurl" or return; my @git_project_url_list = map { chomp; $_ } <$fd>; close $fd; ```