# [PATCH resend] graph: improve grammar of "invalid color" error message 3 messages from 2021-06-12 to 2021-06-15. Participants: Alex Henrie, Bagas Sanjaya, Junio C Hamano. Thread: https://gitlist.dev/t/55911 ## Alex Henrie, 2021-06-12 18:41 Subject: [PATCH resend] graph: improve grammar of "invalid color" error message Message-ID: <20210612184144.6894-1-alexhenrie24@gmail.com> URL: https://gitlist.dev/e/20210612184144.6894-1-alexhenrie24%40gmail.com ``` Without the "d", it sounds like a command, not an error, and is liable to be translated incorrectly. Signed-off-by: Alex Henrie --- Resending to make sure that this patch isn't forgotten. --- graph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/graph.c b/graph.c index c128ad0cce..e3828eb8f2 100644 --- a/graph.c +++ b/graph.c @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string) if (!color_parse_mem(start, comma - start, color)) strvec_push(colors, color); else - warning(_("ignore invalid color '%.*s' in log.graphColors"), + warning(_("ignored invalid color '%.*s' in log.graphColors"), (int)(comma - start), start); start = comma + 1; } -- 2.31.1 ``` ## Bagas Sanjaya, 2021-06-13 02:21 Subject: Re: [PATCH resend] graph: improve grammar of "invalid color" error message Message-ID: <21c43663-9d2a-0173-bd5c-4e2c9f95bc05@gmail.com> URL: https://gitlist.dev/e/21c43663-9d2a-0173-bd5c-4e2c9f95bc05%40gmail.com In-Reply-To: <20210612184144.6894-1-alexhenrie24@gmail.com> ``` Hi, On 13/06/21 01.41, Alex Henrie wrote: > Without the "d", it sounds like a command, not an error, and is liable > to be translated incorrectly. > s/liable/prone/ > Signed-off-by: Alex Henrie > --- > Resending to make sure that this patch isn't forgotten. > --- > graph.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/graph.c b/graph.c > index c128ad0cce..e3828eb8f2 100644 > --- a/graph.c > +++ b/graph.c > @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string) > if (!color_parse_mem(start, comma - start, color)) > strvec_push(colors, color); > else > - warning(_("ignore invalid color '%.*s' in log.graphColors"), > + warning(_("ignored invalid color '%.*s' in log.graphColors"), > (int)(comma - start), start); > start = comma + 1; > } > Why did you resend the patch? -- An old man doll... just what I always wanted! - Clara ``` ## Junio C Hamano, 2021-06-15 03:55 Subject: Re: [PATCH resend] graph: improve grammar of "invalid color" error message Message-ID: URL: https://gitlist.dev/e/xmqqv96fwzlx.fsf%40gitster.g In-Reply-To: <20210612184144.6894-1-alexhenrie24@gmail.com> ``` Alex Henrie writes: > Without the "d", it sounds like a command, not an error, and is liable > to be translated incorrectly. > > Signed-off-by: Alex Henrie > --- > Resending to make sure that this patch isn't forgotten. Thanks, will queue. > --- > graph.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/graph.c b/graph.c > index c128ad0cce..e3828eb8f2 100644 > --- a/graph.c > +++ b/graph.c > @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string) > if (!color_parse_mem(start, comma - start, color)) > strvec_push(colors, color); > else > - warning(_("ignore invalid color '%.*s' in log.graphColors"), > + warning(_("ignored invalid color '%.*s' in log.graphColors"), > (int)(comma - start), start); > start = comma + 1; > } ```