# [PATCH] help: fix small typo in error message

3 messages from 2021-05-20 to 2021-05-20. Participants: Jean-Noël Avila, Jonathan Nieder, Junio C Hamano.
Thread: https://gitlist.dev/t/55744

## Jean-Noël Avila, 2021-05-20 07:42

Subject: [PATCH] help: fix small typo in error message
Message-ID: <20210520074214.40903-1-jn.avila@free.fr>
URL: https://gitlist.dev/e/20210520074214.40903-1-jn.avila%40free.fr

```
Classic string concatenation while forgetting a space character.

Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
---
 list-objects-filter-options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
index 96a605c8ad..fd8d59f653 100644
--- a/list-objects-filter-options.c
+++ b/list-objects-filter-options.c
@@ -102,7 +102,7 @@ static int gently_parse_list_objects_filter(
 	} else if (skip_prefix(arg, "object:type=", &v0)) {
 		int type = type_from_string_gently(v0, strlen(v0), 1);
 		if (type < 0) {
-			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is"
+			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is "
 					      "not a valid object type"), v0);
 			return 1;
 		}
-- 
2.31.0.rc2.1.gaceb20851f.dirty


```

## Jonathan Nieder, 2021-05-20 21:36

Subject: Re: [PATCH] help: fix small typo in error message
Message-ID: <YKbWZMTW2Evux1VR@google.com>
URL: https://gitlist.dev/e/YKbWZMTW2Evux1VR%40google.com
In-Reply-To: <20210520074214.40903-1-jn.avila@free.fr>

```
(cc: pks)
Jean-Noël Avila wrote:

> Classic string concatenation while forgetting a space character.
>
> Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
> ---
[...]
> -			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is"
> +			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is "
>  					      "not a valid object type"), v0);

Good catch!

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

```

## Junio C Hamano, 2021-05-20 22:53

Subject: Re: [PATCH] help: fix small typo in error message
Message-ID: <xmqqbl95t3u4.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqqbl95t3u4.fsf%40gitster.g
In-Reply-To: <20210520074214.40903-1-jn.avila@free.fr>

```
Jean-Noël Avila <jn.avila@free.fr> writes:

> Classic string concatenation while forgetting a space character.
>
> Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
> ---
>  list-objects-filter-options.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks.  This is a new message added in this round, so let's
fast-track this fix down.



> diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
> index 96a605c8ad..fd8d59f653 100644
> --- a/list-objects-filter-options.c
> +++ b/list-objects-filter-options.c
> @@ -102,7 +102,7 @@ static int gently_parse_list_objects_filter(
>  	} else if (skip_prefix(arg, "object:type=", &v0)) {
>  		int type = type_from_string_gently(v0, strlen(v0), 1);
>  		if (type < 0) {
> -			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is"
> +			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is "
>  					      "not a valid object type"), v0);
>  			return 1;
>  		}

```